View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0009133ParaViewBugpublic2009-06-10 13:562010-05-04 20:02
ReporterKen Moreland 
Assigned ToKen Moreland 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version3.8Fixed in Version3.10 
Summary0009133: Wireframe for quadratic faces is wrong
DescriptionWhen you turn on the wireframe for a data set that has quadratic elements, you get lines for all the internal edges created for the approximation. The wireframe should just be the lines around the actual cells.
TagsNo tags attached.
Project
Topic Name
Type
Attached Filespatch file icon NonlinearSubdivisions4.patch [^] (55,821 bytes) 2009-06-10 18:26 [Show Content]
patch file icon NonlinearSubdivisions6.patch [^] (83,364 bytes) 2009-06-12 15:08 [Show Content]
patch file icon NonlinearSubdivisions9.patch [^] (95,916 bytes) 2010-01-22 12:01 [Show Content]
patch file icon NonlinearSurface10.VTK.patch [^] (63,517 bytes) 2010-04-21 17:03 [Show Content]
patch file icon NonlinearSurface10.ParaView.patch [^] (37,736 bytes) 2010-04-21 17:03 [Show Content]
patch file icon NonlinearSurface11.VTK.patch [^] (58,621 bytes) 2010-04-22 20:07 [Show Content]
patch file icon NonlinearSurface11.ParaView.patch [^] (72,664 bytes) 2010-04-22 20:08 [Show Content]

 Relationships
related to 0009132closedKen Moreland Ability to control subdivision of quadratic faces 
related to 0010676closedKen Moreland Wireframe for quadratic faces still wrong for client/server 
related to 0010677closedKen Moreland Internal fields for rendering quadratic surfaces exposed 

  Notes
(0016700)
Ken Moreland (manager)
2009-06-10 18:29

I've attached a patch that I think gets through about 75% of the work. It subdivides nonlinear faces to a chosen level (really bug 0009132) and then extracts an appropriate wireframe for the tessellated faces. There is some wiring to fix up (it does the wireframe all the time right now), but that should not be too hard. The part that I am struggling with is how to show only the "front" facing lines.
(0016719)
Ken Moreland (manager)
2009-06-12 16:11

The latest patch (NonlinearSubdivisions6.patch) mostly resolves the problem. Rendering wireframe with edges mode works pretty well. Simple wireframe mode is still showing all edges (not sure why). The approach is slightly different than that in the previous patch. To get rid of the extra edges, an edge flag is added to the point data. I had to change some painter code to support edge flags (which are supported by OpenGL 1.1).

Selecting nonlinear cells is also broken in this patch.
(0019272)
Ken Moreland (manager)
2010-01-22 12:06

The work is done! Because the changes touch some core classes, I am waiting for someone at Kitware to review the changes. I am assigning this bug to Utkarsh so that he can review the changes. When/if he approves them, he can assign the bug back to me and I will check in the code.

The latest patch, NonlinearSubdivisions9.patch, contains all the necessary changes. I also have the code waiting in a github repository if that is easier. The URL for the repository is <git://github.com/kmorel/ParaView.git> [^] and the change is in the branch <NonlinearSurface>. You can see a summary on this github.com page.

http://github.com/kmorel/ParaView/tree/NonlinearSurface [^]
(0020339)
Ken Moreland (manager)
2010-04-21 17:09

Due to the transition from CVS to git and other changes to files, I have uploaded new patches. Because ParaView and VTK are now separate modules and the changes span both, I have attached a separate patch for each of them. I have also created new repositories on github for direct git access.

http://github.com/kmorel/VTK-NonlinearSurface [^]
http://github.com/kmorel/ParaView-NonlinearSurface [^]
(0020368)
Ken Moreland (manager)
2010-04-22 20:09

Odd. I must have done a diff against the wrong git commit the last time I made the patches. Attached are new versions. Also including VTK_POLYHEDRON as a linear cell type.
(0020430)
Ken Moreland (manager)
2010-04-27 12:54

Pushed changes to the central repository.

VTK commits:
http://vtk.org/gitweb?p=VTK.git;a=commit;h=175efdc2937b89cef01f10cc6fbd0f2b3c1e313f [^]
http://vtk.org/gitweb?p=VTK.git;a=commit;h=b1778f69d6c38b828f7e28d7d43662084a15d320 [^]

ParaView commits:
http://paraview.org/gitweb?p=ParaView.git;a=commit;h=61f83397853c4a4c351ca8168e6d978b953b50e0 [^]
(0020573)
Alan Scott (manager)
2010-05-04 20:02

Tested local server, trunk, Windows.

 Issue History
Date Modified Username Field Change
2009-06-10 13:56 Ken Moreland New Issue
2009-06-10 13:56 Ken Moreland Status backlog => tabled
2009-06-10 13:56 Ken Moreland Assigned To => Ken Moreland
2009-06-10 13:56 Ken Moreland Relationship added related to 0009132
2009-06-10 18:26 Ken Moreland File Added: NonlinearSubdivisions4.patch
2009-06-10 18:29 Ken Moreland Note Added: 0016700
2009-06-12 15:08 Ken Moreland File Added: NonlinearSubdivisions6.patch
2009-06-12 16:11 Ken Moreland Note Added: 0016719
2010-01-22 12:02 Ken Moreland File Added: NonlinearSubdivisions9.patch
2010-01-22 12:02 Ken Moreland Assigned To Ken Moreland => Utkarsh Ayachit
2010-01-22 12:06 Ken Moreland Note Added: 0019272
2010-02-04 13:03 Utkarsh Ayachit Priority normal => immediate
2010-02-10 09:34 Utkarsh Ayachit Assigned To Utkarsh Ayachit => Berk Geveci
2010-03-01 10:27 Utkarsh Ayachit Assigned To Berk Geveci => Will Schroeder
2010-04-21 17:03 Ken Moreland File Added: NonlinearSurface10.VTK.patch
2010-04-21 17:03 Ken Moreland File Added: NonlinearSurface10.ParaView.patch
2010-04-21 17:09 Ken Moreland Note Added: 0020339
2010-04-22 20:07 Ken Moreland File Added: NonlinearSurface11.VTK.patch
2010-04-22 20:08 Ken Moreland File Added: NonlinearSurface11.ParaView.patch
2010-04-22 20:09 Ken Moreland Note Added: 0020368
2010-04-27 12:52 Ken Moreland Assigned To Will Schroeder => Ken Moreland
2010-04-27 12:54 Ken Moreland Note Added: 0020430
2010-04-27 12:54 Ken Moreland Status tabled => @80@
2010-04-27 12:54 Ken Moreland Fixed in Version => 3.10
2010-04-27 12:54 Ken Moreland Resolution open => fixed
2010-05-04 20:02 Alan Scott Note Added: 0020573
2010-05-04 20:02 Alan Scott Status @80@ => closed
2010-05-05 10:24 Ken Moreland Relationship added related to 0010676
2010-05-05 10:29 Ken Moreland Relationship added related to 0010677


Copyright © 2000 - 2018 MantisBT Team