(0020698)
Marcus D. Hanwell (developer)
2010-05-10 13:35

This is fixed in master, and should be applied in the branch for 3.8.2.

(0020811)
Alan Scott (manager)
2010-05-21 14:36

Not correct yet. When the user selects Bottom-Right, the right axis should be turned on. When the Right axis is no longer needed (for instance, user changes back to Bottom-Left), right axis should turn off.

(0020955)
Utkarsh Ayachit (administrator)
2010-06-09 16:39

Marcus, what is the estimate for effort on this?

(0021214)
Marcus D. Hanwell (developer)
2010-07-02 14:56

I am looking into this now, is this the preferred interaction method for all of the corners? I.e. if the plots were only shown in the top-right, then the bottom and left axes would be disabled automatically? If the user were to explicitly show all of the axes, would the act of moving plots around hiding the axes lead to a confusing interface?

It depends on how we expect this to interact with the user explicitly setting visibility of axes which may or may not have plots associated. Some guidance on expectations here would be helpful. It may require some refactoring to have hard settings the user makes, and soft settings which are changed automatically.

(0021415)
Marcus D. Hanwell (developer)
2010-07-16 23:23

I have addressed this, and a couple of other issues we discussed, in commit e7912ac (VTK). I have moved the ParaView VTK submodule forward for these fixes. The new feature is activated by default. This is only in master, and so I will need to backport the change to the release branch if it looks good.

(0021427)
Alan Scott (manager)
2010-07-19 19:47

Very close. A few issues:

When I select DISPL (Mag), and select Bottom-Right, the numbers are off the screen to the right. (Note I am using Windows).

Also, when I then click on VEL (Mag), and then back to DISPL (Mag), DISPL (Mag) once again shows Bottom-Left - rather than what it should be - Bottom-Right.

Next, click on VEL (Magnitude). Top-Right.
Note that the top and bottom labels show different numbers - they should be the same!

(0021450)
Alan Scott (manager)
2010-07-21 19:50

This bug shows up even better with disk_out_ref.exo.

Plot over line, and move the Temp to the Top-Right. Temperatures that go from 250 to 950 show up as 25 to 95.

(0021508)
Marcus D. Hanwell (developer)
2010-07-27 17:33

Commit 30687c0 addresses the layout issue, at least in the first instance. I will merge this into master tomorrow morning (it is on the VTK stage if you want to take a look before then - called chart_layout).

(0021511)
Marcus D. Hanwell (developer)
2010-07-28 10:13

ParaView commit 5417043 in master updates the VTK submodule to bring in the layout fixes discussed above. If this looks good then I will work on getting these changes backported to the release branches of VTK and ParaView.

(0021565)
Alan Scott (manager)
2010-07-29 21:47

Very excellent. I could only find one nit.

Follow the primary directions below. Animate forward ONE time frame.

Next, edit View Settings.
General - Text. Type something in here (abc). Apply. Notice how the graph does not resize to allow space for this title.
Left Axis - Title. Type something in here (def). Apply. Notice that this text goes right in the middle of the numbers.
Right Axis - Title. Type something in here (ghi). Apply. Notice that this text is right at the edge of the plot. It should probably be moved left slightly.

Change left axis title to be a font size of 22. Notice that it falls off of the plot. It should be moved left. I suspect there may be issues with the left one also.

It would be really nice go get this fixed correctly, however - if any of this puts the 3.8.1 release at risk, we can probably live with what we have. It will have to be fixed for 3.10.

(0021670)
Marcus D. Hanwell (developer)
2010-08-05 16:48

Backported to the release branch - Dave should be merging this in soon. I will do what I can to improve the layout for any font size.

(0021898)
Utkarsh Ayachit (administrator)
2010-08-23 14:40

Assuming this has been moved to release branch (as per Marcus' last comment).

(0021899)
Marcus D. Hanwell (developer)
2010-08-23 14:43

This was merged in to the release branch. I just merged a larger topic branch that addresses the issue more generally in trunk, but I am not sure how simple it would be to backport to the release branch (using font metrics to size the charts).

(0022352)
Marcus D. Hanwell (developer)
2010-09-26 10:29

Marking this as resolved. As noted, it was improved for 3.8.1 but not fixed properly due to timing issues. It is fixed and using font metrics for whatever size chart you wish to use in master.

(0022503)
Alan Scott (manager)
2010-10-15 20:48

This bug is fixed. I do have one question - a nit.

When I go through this bug, and the follow-on steps listed towards the bottom, the font size of all of the axis titles - and the main title, start with ridiculously small fonts. Do you also see this, and if so, shouldn't we initially use a larger font?

(0022509)
Marcus D. Hanwell (developer)
2010-10-16 17:09

I think this is a separate issue, but the defaults are Arial 12 for the axes, and Arial 12 bold for the axis titles. The chart title defaults to Arial 14 bold, but it looks like that is not respected for some reason. These sizes are quite normal for charts, but we could look at revisiting the default values if you are unhappy with them.

The dust is still settling on some large changes Utkarsh merged in recently, it took me a little while to find the XML file with the defaults. I think this could go to email/discussion rather than this bug report.

(0022722)
Alan Scott (manager)
2010-10-27 21:00

Lets consider thus bug fixed. I still see trivial issues with the font sizes of the titles, but that can be found by someone else and reported. I am also agreeing with the last comment by Marcus.

Tested local server, Windows, trunk.

Issue History
Date Modified	Username	Field	Change
2010-04-22 15:47	Alan Scott	New Issue
2010-04-22 16:17	Utkarsh Ayachit	Status	backlog => tabled
2010-04-22 16:17	Utkarsh Ayachit	Assigned To	=> Marcus D. Hanwell
2010-04-23 09:37	Marcus D. Hanwell	Relationship added	duplicate of 0010387
2010-05-10 13:35	Marcus D. Hanwell	Note Added: 0020698
2010-05-10 13:35	Marcus D. Hanwell	Status	tabled => @80@
2010-05-10 13:35	Marcus D. Hanwell	Fixed in Version	=> 3.8.2
2010-05-10 13:35	Marcus D. Hanwell	Resolution	open => fixed
2010-05-21 14:36	Alan Scott	Note Added: 0020811
2010-05-21 14:36	Alan Scott	Status	@80@ => @20@
2010-05-21 14:36	Alan Scott	Resolution	fixed => reopened
2010-06-09 16:39	Utkarsh Ayachit	Note Added: 0020955
2010-06-09 16:39	Utkarsh Ayachit	Status	@20@ => tabled
2010-06-15 09:44	Utkarsh Ayachit	Target Version	3.8.2 => 3.8.1
2010-06-15 09:45	Utkarsh Ayachit	Fixed in Version	3.8.2 => 3.8.1
2010-06-15 09:49	Utkarsh Ayachit	Fixed in Version	3.8.1 =>
2010-07-02 14:56	Marcus D. Hanwell	Note Added: 0021214
2010-07-16 23:23	Marcus D. Hanwell	Note Added: 0021415
2010-07-19 19:47	Alan Scott	Note Added: 0021427
2010-07-19 19:47	Alan Scott	Status	tabled => @20@
2010-07-21 19:50	Alan Scott	Note Added: 0021450
2010-07-27 17:33	Marcus D. Hanwell	Note Added: 0021508
2010-07-27 17:33	Marcus D. Hanwell	Status	@20@ => tabled
2010-07-28 10:13	Marcus D. Hanwell	Note Added: 0021511
2010-07-28 10:13	Marcus D. Hanwell	Status	tabled => @80@
2010-07-28 10:13	Marcus D. Hanwell	Fixed in Version	=> Development
2010-07-28 10:13	Marcus D. Hanwell	Resolution	reopened => fixed
2010-07-29 21:47	Alan Scott	Note Added: 0021565
2010-07-29 21:47	Alan Scott	Status	@80@ => @20@
2010-07-29 21:47	Alan Scott	Resolution	fixed => reopened
2010-08-05 16:48	Marcus D. Hanwell	Note Added: 0021670
2010-08-05 16:48	Marcus D. Hanwell	Status	@20@ => tabled
2010-08-23 14:40	Utkarsh Ayachit	Note Added: 0021898
2010-08-23 14:40	Utkarsh Ayachit	Fixed in Version	Development => 3.8.1
2010-08-23 14:43	Marcus D. Hanwell	Note Added: 0021899
2010-09-26 10:29	Marcus D. Hanwell	Note Added: 0022352
2010-09-26 10:29	Marcus D. Hanwell	Status	tabled => @80@
2010-09-26 10:29	Marcus D. Hanwell	Resolution	reopened => fixed
2010-10-15 20:48	Alan Scott	Note Added: 0022503
2010-10-15 20:48	Alan Scott	Status	@80@ => @20@
2010-10-15 20:48	Alan Scott	Resolution	fixed => reopened
2010-10-16 17:09	Marcus D. Hanwell	Note Added: 0022509
2010-10-16 17:09	Marcus D. Hanwell	Status	@20@ => @80@
2010-10-16 17:09	Marcus D. Hanwell	Resolution	reopened => fixed
2010-10-27 21:00	Alan Scott	Note Added: 0022722
2010-10-27 21:00	Alan Scott	Status	@80@ => closed
2011-01-13 17:00		Source_changeset_attached	=> VTK master a2bd8391
2011-01-13 17:00		Source_changeset_attached	=> VTK master 020ef709

Notes
(0020698) Marcus D. Hanwell (developer) 2010-05-10 13:35	This is fixed in master, and should be applied in the branch for 3.8.2.

(0020811) Alan Scott (manager) 2010-05-21 14:36	Not correct yet. When the user selects Bottom-Right, the right axis should be turned on. When the Right axis is no longer needed (for instance, user changes back to Bottom-Left), right axis should turn off.

(0020955) Utkarsh Ayachit (administrator) 2010-06-09 16:39	Marcus, what is the estimate for effort on this?

(0021214) Marcus D. Hanwell (developer) 2010-07-02 14:56	I am looking into this now, is this the preferred interaction method for all of the corners? I.e. if the plots were only shown in the top-right, then the bottom and left axes would be disabled automatically? If the user were to explicitly show all of the axes, would the act of moving plots around hiding the axes lead to a confusing interface? It depends on how we expect this to interact with the user explicitly setting visibility of axes which may or may not have plots associated. Some guidance on expectations here would be helpful. It may require some refactoring to have hard settings the user makes, and soft settings which are changed automatically.

(0021415) Marcus D. Hanwell (developer) 2010-07-16 23:23	I have addressed this, and a couple of other issues we discussed, in commit e7912ac (VTK). I have moved the ParaView VTK submodule forward for these fixes. The new feature is activated by default. This is only in master, and so I will need to backport the change to the release branch if it looks good.

(0021427) Alan Scott (manager) 2010-07-19 19:47	Very close. A few issues: When I select DISPL (Mag), and select Bottom-Right, the numbers are off the screen to the right. (Note I am using Windows). Also, when I then click on VEL (Mag), and then back to DISPL (Mag), DISPL (Mag) once again shows Bottom-Left - rather than what it should be - Bottom-Right. Next, click on VEL (Magnitude). Top-Right. Note that the top and bottom labels show different numbers - they should be the same!

(0021450) Alan Scott (manager) 2010-07-21 19:50	This bug shows up even better with disk_out_ref.exo. Plot over line, and move the Temp to the Top-Right. Temperatures that go from 250 to 950 show up as 25 to 95.

(0021508) Marcus D. Hanwell (developer) 2010-07-27 17:33	Commit 30687c0 addresses the layout issue, at least in the first instance. I will merge this into master tomorrow morning (it is on the VTK stage if you want to take a look before then - called chart_layout).

(0021511) Marcus D. Hanwell (developer) 2010-07-28 10:13	ParaView commit 5417043 in master updates the VTK submodule to bring in the layout fixes discussed above. If this looks good then I will work on getting these changes backported to the release branches of VTK and ParaView.

(0021565) Alan Scott (manager) 2010-07-29 21:47	Very excellent. I could only find one nit. Follow the primary directions below. Animate forward ONE time frame. Next, edit View Settings. General - Text. Type something in here (abc). Apply. Notice how the graph does not resize to allow space for this title. Left Axis - Title. Type something in here (def). Apply. Notice that this text goes right in the middle of the numbers. Right Axis - Title. Type something in here (ghi). Apply. Notice that this text is right at the edge of the plot. It should probably be moved left slightly. Change left axis title to be a font size of 22. Notice that it falls off of the plot. It should be moved left. I suspect there may be issues with the left one also. It would be really nice go get this fixed correctly, however - if any of this puts the 3.8.1 release at risk, we can probably live with what we have. It will have to be fixed for 3.10.

(0021670) Marcus D. Hanwell (developer) 2010-08-05 16:48	Backported to the release branch - Dave should be merging this in soon. I will do what I can to improve the layout for any font size.

(0021898) Utkarsh Ayachit (administrator) 2010-08-23 14:40	Assuming this has been moved to release branch (as per Marcus' last comment).

(0021899) Marcus D. Hanwell (developer) 2010-08-23 14:43	This was merged in to the release branch. I just merged a larger topic branch that addresses the issue more generally in trunk, but I am not sure how simple it would be to backport to the release branch (using font metrics to size the charts).

(0022352) Marcus D. Hanwell (developer) 2010-09-26 10:29	Marking this as resolved. As noted, it was improved for 3.8.1 but not fixed properly due to timing issues. It is fixed and using font metrics for whatever size chart you wish to use in master.

(0022503) Alan Scott (manager) 2010-10-15 20:48	This bug is fixed. I do have one question - a nit. When I go through this bug, and the follow-on steps listed towards the bottom, the font size of all of the axis titles - and the main title, start with ridiculously small fonts. Do you also see this, and if so, shouldn't we initially use a larger font?

(0022509) Marcus D. Hanwell (developer) 2010-10-16 17:09	I think this is a separate issue, but the defaults are Arial 12 for the axes, and Arial 12 bold for the axis titles. The chart title defaults to Arial 14 bold, but it looks like that is not respected for some reason. These sizes are quite normal for charts, but we could look at revisiting the default values if you are unhappy with them. The dust is still settling on some large changes Utkarsh merged in recently, it took me a little while to find the XML file with the defaults. I think this could go to email/discussion rather than this bug report.

(0022722) Alan Scott (manager) 2010-10-27 21:00	Lets consider thus bug fixed. I still see trivial issues with the font sizes of the titles, but that can be found by someone else and reported. I am also agreeing with the last comment by Marcus. Tested local server, Windows, trunk.