View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0012619

VTK

(No Category)

public

2011-09-29 03:37

2013-07-22 19:45

Reporter

Sven Buijssen

Assigned To

David Partyka

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

5.8.0

Target Version

5.8.1

Fixed in Version

5.10.0

Summary

0012619: Null pointer dereference in class vtkPolyDataSilhouetteEdges

Description

Use the attached XML plugin to expose vtkPolyDataSilhouetteEdges as filter in ParaView (Tools - Manage Plugins - Load New...)
Sources - Cone - Apply
Filters - Silhouette Edges - Apply
Uncheck "Enable Feature Angle" - Apply

=> Program received signal SIGSEGV, Segmentation fault.
0x00007fffe3337673 in vtkPolyDataSilhouette::RequestData (this=0x286cfe0, inputVector=0x2876290, outputVector=0x286f610)
at /ParaView3.git/VTK/Hybrid/vtkPolyDataSilhouette.cxx:258
258 ( this->Camera->GetMTime() > output->GetMTime() ) ||

(gdb) print this->Camera
$1 = (class vtkCamera *) 0x0

Tags

No tags attached.

Project

TBD

Type

crash

Attached Files

vtkPolyDataSilhouette.xml [^] (3,485 bytes) 2011-09-29 03:37

0001-BUG-Fix-for-BUG-12619.-vtkPolyDataSilhouette-segfaul.patch [^] (1,057 bytes) 2011-09-29 03:41 [Show Content] [Hide Content]

From 0c9d7f19f62b19dadf1e65ee4ff71786cb3b5f39 Mon Sep 17 00:00:00 2001
From: Sven Buijssen <sven.buijssen@tu-dortmund.de>
Date: Thu, 29 Sep 2011 09:38:50 +0200
Subject: BUG: Fix for BUG #12619. vtkPolyDataSilhouette segfaulted if no camera

---
 Hybrid/vtkPolyDataSilhouette.cxx |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Hybrid/vtkPolyDataSilhouette.cxx b/Hybrid/vtkPolyDataSilhouette.cxx
index e4a45fb..8efe9d0 100644
--- a/Hybrid/vtkPolyDataSilhouette.cxx
+++ b/Hybrid/vtkPolyDataSilhouette.cxx
@@ -255,9 +255,9 @@ int vtkPolyDataSilhouette::RequestData(
     }
 
   if( ( this->PreComp->mtime.GetMTime() > output->GetMTime() ) ||
-    ( this->Camera->GetMTime() > output->GetMTime() ) ||
-    ( this->Prop3D!=0 && this->Prop3D->GetMTime() > output->GetMTime() ) ||
-    vecChanged )
+      ( this->Camera && this->Camera->GetMTime() > output->GetMTime() ) ||
+      ( this->Prop3D && this->Prop3D->GetMTime() > output->GetMTime() ) ||
+      vecChanged )
     {
     vtkDebugMacro(<<"Extract edges\n");
 
-- 
1.7.6.3

Relationships

Notes
(0027532) Sven Buijssen (reporter) 2011-09-29 03:41	Suggested patch attached.

(0027748) David Partyka (developer) 2011-11-30 11:46	Merged the vtk change into vtk master/release. The ParaView xml plugin will take a little extra work to battle with the new work flow.

Issue History
Date Modified	Username	Field	Change
2011-09-29 03:37	Sven Buijssen	New Issue
2011-09-29 03:37	Sven Buijssen	File Added: vtkPolyDataSilhouette.xml
2011-09-29 03:41	Sven Buijssen	File Added: 0001-BUG-Fix-for-BUG-12619.-vtkPolyDataSilhouette-segfaul.patch
2011-09-29 03:41	Sven Buijssen	Note Added: 0027532
2011-09-29 08:20	David Partyka	Assigned To	=> David Partyka
2011-09-29 08:20	David Partyka	Status	backlog => tabled
2011-09-29 08:20	David Partyka	Target Version	=> 5.8.1
2011-11-30 11:45	David Partyka	Status	tabled => todo
2011-11-30 11:45	David Partyka	Resolution	open => fixed
2011-11-30 11:45	David Partyka	Status	todo => active development
2011-11-30 11:46	David Partyka	Note Added: 0027748
2011-11-30 11:46	David Partyka	Status	active development => gatekeeper review
2011-11-30 12:00	David Partyka	Source_changeset_attached	=> VTK master c5054715
2013-07-22 19:45	Dave DeMarle	Status	gatekeeper review => closed
2013-07-22 19:45	Dave DeMarle	Fixed in Version	=> 5.10.0