View Issue Details [ Jump to Notes ]

[ Print ]

Project

Category

View Status

Date Submitted

Last Update

0011697

ParaView

Bug

public

2011-01-14 10:30

2012-02-08 17:24

Reporter

Paul Edwards

Assigned To

Kyle Lutz

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Development

Target Version

3.12

Fixed in Version

3.12

Summary

0011697: All points are converted to floating point when run through D3

Description

The points datatype is always float regardless of the datatype going in.

Steps To Reproduce

Run attached script. Output:

8<-----------------------------------------------------------------
paul@localhost:~/d3test$ pvpython d3-bug-double-precision-points-lost.py
Listen on port: 11111
Waiting for client...
Client connected.
vtkSphereSource : [ ...........]
vtkSphereSource(1) : [ ...........]
vtkSphereSource : [ ...........]
Process id: 0 >> Datatype is 11
Process id: 1 >> Datatype is 11
vtkPythonProgrammableFilter(1) : [ ...........]
vtkDistributedDataFilter(1) : [ ...........]
Clean up and finish : [ ...........]
vtkPythonProgrammableFilter(1) : [ ...........]
Process id: 0 >> Datatype is 10
Process id: 1 >> Datatype is 10
paul@localhost:~/d3test$
----------------------------------------------------------------->8

Additional Information

Additional point data will stay the same type - it is only for the coordinates.

Tags

No tags attached.

Project

TBD

Topic Name

11697-fix-d3-data-type

Type

incorrect functionality

Attached Files

d3-bug-double-precision-points-lost.py [^] (1,158 bytes) 2011-09-05 05:54

d3-bug-double-precision-points-lost.patch [^] (571 bytes) 2011-09-05 05:55 [Show Content] [Hide Content]

diff --git a/Graphics/vtkExtractCells.cxx b/Graphics/vtkExtractCells.cxx
index 81a082b..22936c5 100644
--- a/Graphics/vtkExtractCells.cxx
+++ b/Graphics/vtkExtractCells.cxx
@@ -197,6 +197,11 @@ int vtkExtractCells::RequestData(
   newCD->CopyAllocate(CD, numCells);
 
   vtkPoints *pts = vtkPoints::New();
+  if(vtkPointSet* inputPS = vtkPointSet::SafeDownCast(input))
+    {
+    // preserve input datatype
+    pts->SetDataType(inputPS->GetPoints()->GetDataType());
+    }
   pts->SetNumberOfPoints(numPoints);
 
   for (vtkIdType newId =0; newId<numPoints; newId++)

Relationships

Notes
(0027453) Paul Edwards (reporter) 2011-09-05 05:56	I just realised I didn't add the python test. I have also added a patch to fix the issue.

(0027454) Kyle Lutz (viewer) 2011-09-05 10:23	Merge topic '11697-fix-d3-data-type' into pv-next 9aa84ed Perserve original data type in D3 filter Merge topic '11697-fix-d3-data-type' into next f54995e Update VTK to bring in '11697-fix-d3-data-type'

(0027455) Kyle Lutz (viewer) 2011-09-05 10:24	Test output with patch applied: $ ./pvpython /home/kyle/Downloads/d3-bug-double-precision-points-lost.py Waiting for client Connection URL: cs://localhost:11111 Client connected. Datatype is 11 Datatype is 11 Datatype is 11 Datatype is 11 Exiting... Exiting...

(0027467) Utkarsh Ayachit (administrator) 2011-09-09 14:14	merged into git-master.

(0028143) Utkarsh Ayachit (administrator) 2012-02-08 17:24	Closing bugs sitting in "customer review" for a long time.

Issue History
Date Modified	Username	Field	Change
2011-01-14 10:30	Paul Edwards	New Issue
2011-01-20 09:39	Utkarsh Ayachit	Assigned To	=> Utkarsh Ayachit
2011-01-20 09:39	Utkarsh Ayachit	Status	backlog => tabled
2011-09-05 05:54	Paul Edwards	File Added: d3-bug-double-precision-points-lost.py
2011-09-05 05:55	Paul Edwards	File Added: d3-bug-double-precision-points-lost.patch
2011-09-05 05:56	Paul Edwards	Note Added: 0027453
2011-09-05 10:16	Kyle Lutz	Assigned To	Utkarsh Ayachit => Kyle Lutz
2011-09-05 10:16	Kyle Lutz	Status	backlog => todo
2011-09-05 10:16	Kyle Lutz	Status	todo => active development
2011-09-05 10:23	Kyle Lutz	Topic Name	=> 11697-fix-d3-data-type
2011-09-05 10:23	Kyle Lutz	Note Added: 0027454
2011-09-05 10:23	Kyle Lutz	Status	active development => gatekeeper review
2011-09-05 10:23	Kyle Lutz	Resolution	open => fixed
2011-09-05 10:24	Kyle Lutz	Note Added: 0027455
2011-09-06 09:07	Utkarsh Ayachit	Project	=> TBD
2011-09-06 09:07	Utkarsh Ayachit	Type	=> incorrect functionality
2011-09-06 09:07	Utkarsh Ayachit	Target Version	=> 3.12
2011-09-09 14:13	Utkarsh Ayachit	Fixed in Version	=> git-master
2011-09-09 14:14	Utkarsh Ayachit	Status	gatekeeper review => customer review
2011-09-09 14:14	Utkarsh Ayachit	Note Added: 0027467
2011-11-11 17:03	Utkarsh Ayachit	Fixed in Version	git-master => 3.12
2012-02-08 17:24	Utkarsh Ayachit	Status	customer review => closed
2012-02-08 17:24	Utkarsh Ayachit	Note Added: 0028143