View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0009785ParaViewBugpublic2009-10-27 16:072011-09-01 13:31
ReporterAlan Scott 
Assigned ToAlan Scott 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOSOS Version
Product VersionDevelopment 
Target Version3.8.1Fixed in Version3.12 
Summary0009785: Extract CTH Parts has bugs
DescriptionWe are finding bugs with the ExtractCTHParts filter. It seems to be dropping cells. Here is, I believe, a way to replicate these bugs.

ParaView 3.6.2, Linux, numerous servers (16 pvservers, but I bet this can be replicated on fewer).

Open Dave's large CTH dataset.
Filters/ ExtractCTHParts for material volume fraction 1. Default values, Apply.
Select spcta (input dataset) once again.
Filters/ ExtractCTHParts for material volume fraction 2. Default values, Apply.
Leave everything coloring by it's Material volume fraction.
Go to last time step.
Notice that, on the back of the "floor", is an area that looks like it has three missing "tiles".
Go back one more timestep. Notice that there are new areas that are wrong.

I will include a screenshot.

Since this is a primary tool for work on large CTH datasets, this needs to be fixed for 3.8.
Additional InformationHere is how this filter works:

1. Open the data (make sure you select interesting cell arrays or all)
2. Use the filter (Iso Volume).
3. Select the volume fraction value (between 0 and 1)
4. Select Material arrays of interest.
5. Hit Apply.
TagsNo tags attached.
Project
Topic Name
Type
Attached Filespng file icon cthPartsErrors.png [^] (86,865 bytes) 2009-10-27 16:07

 Relationships
related to 0010841closedUtkarsh Ayachit Lighting incorrect for point data with CTH AMR 

  Notes
(0020064)
Utkarsh Ayachit (administrator)
2010-04-02 15:50

Charles has committed "vtkAMRClip" filter to ParaView. This filter is to become a replacement for ExtractCTHParts. Currently it only accepts 1 material selection. Create a new class that accepts multiple material selections, internally using vtkAMRClip multiple times to extract the parts and produce a vtkMultiBlockDataSet of the fragments.
(0020314)
Alan Scott (manager)
2010-04-20 19:04

waiting for your feedback on what to do with the amr clip/contour and extractCTHParts filters.
(0020646)
Utkarsh Ayachit (administrator)
2010-05-07 14:11
edited on: 2010-05-07 14:11

The current plan is as follows:
* Update "Clip" filter in ParaView to use vtkAMRClip when clipping with scalar for an AMR dataset.
* Update "Contour" filter in ParaView to use vtkAMRContour when contouring an AMR dataset.
* Since IsoVolume filter uses "Clip with scalar" internally, it should use this "new AMR-smart Clip" filter, thus doing the smart thing for AMR datasets when doing an IsoVolume.

We will leave the current "Extract CTH Parts" as is for backwards compatibility.

(0020817)
user3172
2010-05-24 15:23

Open dave's small cth dataset, as per below. All arrays on, otherwise, default. Note that all arrays are cells.
* Threshold. Material Volume Fraction - 1. Use 128. Apply.
 - Bug - visibility is wrong on the original dataset. It should go off. Bug 10745.
 - Object looks correct.
* Isovolume. Material Volume Fraction - 1. Use 128. Apply.
 - Bug - visibility is wrong on the original dataset. It should go off. Bug 10745.
 - Object looks correct.
* amrContour. Material Volume Fraction - 1. Use 128. Apply.
 - Visibility is correct.
 - Object looks correct? It is smooth, which is what we want, right?
* clip by plane.
 - Bug - visibility is wrong on the original dataset. It should go off. Bug 10745.
 - Bug - When you turn visibility on/off correctly, nothing shows up! This is a high level bug.
* clip by scalar. Material Volume Fraction - 1. Use 128. Apply.
 - Bug - visibility is wrong on the original dataset. It should go off. Bug 10745.
 - Bug - When you turn visibility on/off correctly, clips like we are clipping points (smooth). Should look like threshold.

Now, lets convert everything to points, and try again.
* Cell to point filter.
* Threshold. Material Volume Fraction - 1. Use 128. Apply.
 - Bug - visibility is wrong on the original dataset. It should go off. Bug 10745.
 - Object looks correct. It looks blocky.
* Isovolume. Material Volume Fraction - 1. Use 128. Apply.
 - Bug - Crash. This must be fixed for 3.8.2.
* amrContour. Material Volume Fraction - 1. Use 128. Apply.
 - Greyed out. Probably OK.
* clip by plane.
 - Bug - visibility is wrong on the original dataset. It should go off. Bug 10745.
 - Bug - When you turn visibility on/off correctly, nothing shows up! This is a high level bug.
* clip by scalar. Material Volume Fraction - 1. Use 128. Apply.
 - Bug - visibility is wrong on the original dataset. It should go off. Bug 10745.
 - Bug - When you turn visibility on/off correctly, nothing shows up! This also is high priority.
(0020857)
user3172
2010-05-28 10:19

git commit: 4391b4f1c7ae4f3ee56383de98fae31010f36f7d

For testing (as IsoVolume uses Clip internall now):

IsoVolume:

1. Wavelet source:
a. Set the "Lower Threshold" to 100 Upper to 150.
b. Use point data to cell data filer.
c. Set the "Lower Threshold" to 100 Upper to 150. (this looks blockier now).

2. Multiblock DataSet:
a. Load data "can.ex2" from ParaView data repository.
b. Select PedigreeElementId for "Scalars". Set the "Lower Threshold" to 4000 Upper to 5000.
c. Select GlobalNodeId for "Scalars". Set the "Lower Threshold" to 6000 Upper to 10088.

3. AMR DataSet:
a. Load "restarted/spcth" dataset from ParaView data repository.
b. Select "Material volume fraction -3". Set the "Lower Threshold" to 0 (default) and "Upper Threshold" to 255 (default)

Some additional notes:
=====================
Bug - When you turn visibility on/off correctly, clips like we are clipping points (smooth). Should look like threshold.

--> It wont as AMR with cell scalars it uses AMRDualClip.

Fixed the bugs except for the visibility bug. Thats has nothing to do with the filter. After talking to Utkarsh, it seems like he is going to take care of it.

(0020899)
Utkarsh Ayachit (administrator)
2010-06-02 11:12

commit cf567ed94551cf2179e90c675c58b1a19bcf9cff
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Jun 2 11:10:29 2010 -0400

    Fixed BUG 0009785.
    
    When clipping AMR with point arrays, we need to use the superclass
    implementation, not threshold (as was the case).
    
    Reorganized code to make it easier to call superclass implementation.
(0021049)
Alan Scott (manager)
2010-06-16 17:07

Adding a relationship.
(0021050)
Alan Scott (manager)
2010-06-16 17:15

I believe this is fixed, with the exception of the new bug, with link from here. Nice cleanup!

Tested local server, trunk, Windows.

 Issue History
Date Modified Username Field Change
2009-10-27 16:07 Alan Scott New Issue
2009-10-27 16:07 Alan Scott File Added: cthPartsErrors.png
2010-02-01 14:25 Utkarsh Ayachit Priority normal => immediate
2010-03-17 15:28 Utkarsh Ayachit Status backlog => tabled
2010-03-17 15:28 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2010-04-02 15:48 Utkarsh Ayachit Assigned To Utkarsh Ayachit => user3172
2010-04-02 15:50 Utkarsh Ayachit Note Added: 0020064
2010-04-02 15:50 Utkarsh Ayachit Target Version 3.8 => 3.8.2
2010-04-15 15:22 user3172 Status tabled => @80@
2010-04-15 15:22 user3172 Resolution open => fixed
2010-04-15 15:22 user3172 Additional Information Updated
2010-04-20 19:04 Alan Scott Assigned To user3172 => Utkarsh Ayachit
2010-04-20 19:04 Alan Scott Note Added: 0020314
2010-04-20 19:04 Alan Scott Status @80@ => @20@
2010-04-20 19:04 Alan Scott Resolution fixed => reopened
2010-05-07 14:08 Utkarsh Ayachit Status @20@ => tabled
2010-05-07 14:08 Utkarsh Ayachit Assigned To Utkarsh Ayachit => user3172
2010-05-07 14:11 Utkarsh Ayachit Note Added: 0020646
2010-05-07 14:11 Utkarsh Ayachit Note Edited: 0020646
2010-05-20 17:17 user3172 Status tabled => @80@
2010-05-20 17:17 user3172 Resolution reopened => fixed
2010-05-24 15:23 user3172 Note Added: 0020817
2010-05-24 15:23 user3172 Status @80@ => @20@
2010-05-24 15:23 user3172 Resolution fixed => reopened
2010-05-28 10:19 user3172 Note Added: 0020857
2010-05-28 10:19 user3172 Status @20@ => @80@
2010-05-28 10:19 user3172 Resolution reopened => fixed
2010-05-28 10:19 user3172 Product Version => Development
2010-06-02 11:12 Utkarsh Ayachit Note Added: 0020899
2010-06-15 09:44 Utkarsh Ayachit Target Version 3.8.2 => 3.8.1
2010-06-16 17:07 Alan Scott Note Added: 0021049
2010-06-16 17:07 Alan Scott Assigned To user3172 => Alan Scott
2010-06-16 17:07 Alan Scott Status @80@ => tabled
2010-06-16 17:07 Alan Scott Relationship added related to 0010841
2010-06-16 17:15 Alan Scott Note Added: 0021050
2010-06-16 17:15 Alan Scott Status tabled => closed
2010-07-07 09:55 Utkarsh Ayachit Fixed in Version => Development
2011-09-01 13:31 Utkarsh Ayachit Fixed in Version Development => 3.12


Copyright © 2000 - 2018 MantisBT Team