View Issue Details Jump to Notes ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0006955VTK(No Category)public2008-05-05 12:002013-04-05 19:57
ReporterKen Moreland 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
Summary0006955: vtkInformation::CopyEntry ignores deep flag
DescriptionMany of the forms of the CopyEntry method in vtkInformation ignore their deep flag. Instead they always do a shallow copy, which of course can lead to some surprising results when a DeepCopy of a vtkInformation or its entries is performed.

I attached a patch to vtkInformation.cxx that should fix the problem.
TagsNo tags attached.
Project
Type
Attached Filespatch file icon vtkInformation.cxx.patch [^] (4,474 bytes) 2008-05-05 12:00 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
child of 0006956closedUtkarsh Ayachit ParaView Temporal statistics filter output reports wrong ranges 

-  Notes
(0013199)
Utkarsh Ayachit (administrator)
2008-08-27 08:59

It seems like none of the vtkInformationKey subclasses provide an implementation for DeepCopy().
(0013202)
Ken Moreland (developer)
2008-08-27 10:18

Hmm. I must not have noticed that because in my case the missing keys were being recreated again after the copy.

It seems to me that vtkInformationKey::DeepCopy should be a pure virtual class (like ShallowCopy), which would force all of the subclasses to provide an implementation.
(0013207)
Utkarsh Ayachit (administrator)
2008-08-27 11:08

Committing Ken's patch to make vtkInformation::Copy()
respect the deep-copy flag. Also added default vtkInformationKey::DeepCopy()
implementation which simply does a shallow copy.

/cvsroot/ParaView3/ParaView3/VTK/Common/vtkInformation.cxx,v <-- VTK/Common/vtkInformation.cxx
new revision: 1.27; previous revision: 1.26
/cvsroot/ParaView3/ParaView3/VTK/Common/vtkInformationKey.h,v <-- VTK/Common/vtkInformationKey.h
new revision: 1.12; previous revision: 1.11

- Issue History
Date Modified Username Field Change
2008-05-05 12:00 Ken Moreland New Issue
2008-05-05 12:00 Ken Moreland File Added: vtkInformation.cxx.patch
2008-05-05 12:20 Ken Moreland Relationship added child of 0006956
2008-08-26 13:49 Utkarsh Ayachit Status backlog => tabled
2008-08-26 13:49 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2008-08-27 08:59 Utkarsh Ayachit Note Added: 0013199
2008-08-27 10:18 Ken Moreland Note Added: 0013202
2008-08-27 11:08 Utkarsh Ayachit Status tabled => @80@
2008-08-27 11:08 Utkarsh Ayachit Resolution open => fixed
2008-08-27 11:08 Utkarsh Ayachit Note Added: 0013207
2011-06-16 13:11 Zack Galbreath Category => (No Category)
2013-04-05 19:57 Berk Geveci Status customer review => closed


Copyright © 2000 - 2017 MantisBT Team
Powered by Mantis Bugtracker