(0035283)
Utkarsh Ayachit (administrator)
2015-10-14 09:26

A few more things:

+ Change the label for the filter so its more readable e.g. "Flying Edges 3D". Currently it's simply called "FlyingEdges3D". Same for FlyingEdges2D

+ Create a new category to put these filters so it's easier for users to spot these new filters. Maybe create a new "Accelerated Filters" category.

(0035319)
Dan Lipsa (developer)
2015-10-21 09:52

See:
https://gitlab.kitware.com/paraview/paraview/merge_requests/439 [^]

I also added vtkFlyingEdgesPlaneCutter to the list of accelerated filters.

(0035563)
Alan Scott (manager)
2015-12-15 20:11

Note to myself:
* I don't know how to test well. Tried some simple contours on Wavelet and Mandlebrot. Worked.
* Tried Plane Cutter on Wavelet, remote server, plane offset, crashed.

(0035564)
Alan Scott (manager)
2015-12-15 20:16

Moving back to todo. It crashed as follows:

* Linux, remote server (8 servers - redsky), 5.0.0-RC2
* Added the plugin for advanced algorithms.
* Load Whipple Shield 32. All vars on, apply.
* Filters/ Advanced Algorithms/ Flying Edges Plane Cutter. Apply.
Server side dies.

Ask me if you want a call stack with fewer servers. It's a mess, so I haven't included it here.

(0035589)
Utkarsh Ayachit (administrator)
2015-12-17 09:48

MR: https://gitlab.kitware.com/paraview/paraview/merge_requests/536 [^]

Alan, BTW these filters only work on ImageData -- hence won't work on WhippleShield. I've updated the XML so that filter is not enabled anymore for unstructured grid datasets.

I could not reproduce the "Tried Plane Cutter on Wavelet, remote server, plane offset, crashed" crash. Mind elaborating? BTW, these was a bogus "Slice Offset Value" property on the filter that I removed.

(0035590)
Ken Moreland (manager)
2015-12-17 11:32

As we add these accelerated algorithms, at some point they should supplant the standard implementation of the algorithm. Thus, when the user hits the contour button in the standard filters toolbar, it should use the flying edges algorithm when appropriate.

This is of course contingent on the algorithm being robust and feature rich enough to be a replacement. That might be a longer time scale than just adding another filter.

(0035591)
Utkarsh Ayachit (administrator)
2015-12-17 12:05

@ken, yup that's correct. We decided to do it as a plugin for now so people can at least start playing with them without us actually committing to how these continue to work in ParaView in long run. The ultimate goal will indeed be as you say, to supplant standard implementations under the covers.

(0035792)
Alan Scott (manager)
2016-02-24 19:36

Looks good.

Tried running a contour on Whipple Shield, filters were grayed out. Read in the Turtle tiff stack, slice and contour worked fine. Tested 4 nodes, 32 cores, master, Linux client.

Issue History
Date Modified	Username	Field	Change
2015-10-12 09:49	Utkarsh Ayachit	New Issue
2015-10-12 09:49	Utkarsh Ayachit	Assigned To	=> Dan Lipsa
2015-10-12 09:49	Utkarsh Ayachit	Target Version	=> 5.1
2015-10-14 09:26	Utkarsh Ayachit	Note Added: 0035283
2015-10-21 09:52	Dan Lipsa	Status	backlog => active development
2015-10-21 09:52	Dan Lipsa	Note Added: 0035319
2015-10-21 15:44	Dan Lipsa	Status	active development => gatekeeper review
2015-12-11 14:59	Utkarsh Ayachit	Status	gatekeeper review => customer review
2015-12-11 14:59	Utkarsh Ayachit	Resolution	open => fixed
2015-12-11 14:59	Utkarsh Ayachit	Fixed in Version	=> 5.0
2015-12-15 20:11	Alan Scott	Note Added: 0035563
2015-12-15 20:16	Alan Scott	Note Added: 0035564
2015-12-15 20:16	Alan Scott	Status	customer review => todo
2015-12-17 09:36	Utkarsh Ayachit	Assigned To	Dan Lipsa => Utkarsh Ayachit
2015-12-17 09:36	Utkarsh Ayachit	Target Version	5.1 => 5.0
2015-12-17 09:48	Utkarsh Ayachit	Note Added: 0035589
2015-12-17 09:48	Utkarsh Ayachit	Status	todo => gatekeeper review
2015-12-17 11:32	Ken Moreland	Note Added: 0035590
2015-12-17 12:05	Utkarsh Ayachit	Note Added: 0035591
2015-12-17 13:09	Utkarsh Ayachit	Status	gatekeeper review => customer review
2016-02-24 19:36	Alan Scott	Note Added: 0035792
2016-02-24 19:36	Alan Scott	Status	customer review => closed

Notes
(0035283) Utkarsh Ayachit (administrator) 2015-10-14 09:26	A few more things: + Change the label for the filter so its more readable e.g. "Flying Edges 3D". Currently it's simply called "FlyingEdges3D". Same for FlyingEdges2D + Create a new category to put these filters so it's easier for users to spot these new filters. Maybe create a new "Accelerated Filters" category.

(0035319) Dan Lipsa (developer) 2015-10-21 09:52	See: https://gitlab.kitware.com/paraview/paraview/merge_requests/439 [^] I also added vtkFlyingEdgesPlaneCutter to the list of accelerated filters.

(0035563) Alan Scott (manager) 2015-12-15 20:11	Note to myself: * I don't know how to test well. Tried some simple contours on Wavelet and Mandlebrot. Worked. * Tried Plane Cutter on Wavelet, remote server, plane offset, crashed.

(0035564) Alan Scott (manager) 2015-12-15 20:16	Moving back to todo. It crashed as follows: * Linux, remote server (8 servers - redsky), 5.0.0-RC2 * Added the plugin for advanced algorithms. * Load Whipple Shield 32. All vars on, apply. * Filters/ Advanced Algorithms/ Flying Edges Plane Cutter. Apply. Server side dies. Ask me if you want a call stack with fewer servers. It's a mess, so I haven't included it here.

(0035589) Utkarsh Ayachit (administrator) 2015-12-17 09:48	MR: https://gitlab.kitware.com/paraview/paraview/merge_requests/536 [^] Alan, BTW these filters only work on ImageData -- hence won't work on WhippleShield. I've updated the XML so that filter is not enabled anymore for unstructured grid datasets. I could not reproduce the "Tried Plane Cutter on Wavelet, remote server, plane offset, crashed" crash. Mind elaborating? BTW, these was a bogus "Slice Offset Value" property on the filter that I removed.

(0035590) Ken Moreland (manager) 2015-12-17 11:32	As we add these accelerated algorithms, at some point they should supplant the standard implementation of the algorithm. Thus, when the user hits the contour button in the standard filters toolbar, it should use the flying edges algorithm when appropriate. This is of course contingent on the algorithm being robust and feature rich enough to be a replacement. That might be a longer time scale than just adding another filter.

(0035591) Utkarsh Ayachit (administrator) 2015-12-17 12:05	@ken, yup that's correct. We decided to do it as a plugin for now so people can at least start playing with them without us actually committing to how these continue to work in ParaView in long run. The ultimate goal will indeed be as you say, to supplant standard implementations under the covers.

(0035792) Alan Scott (manager) 2016-02-24 19:36	Looks good. Tried running a contour on Whipple Shield, filters were grayed out. Read in the Turtle tiff stack, slice and contour worked fine. Tested 4 nodes, 32 cores, master, Linux client.

Relationships