View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0015344VTK(No Category)public2015-02-25 00:422016-03-07 18:06
ReporterDavid Gobbi 
Assigned ToDavid Gobbi 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version6.0.0 
Target VersionFixed in Version6.3.0 
Summary0015344: SetInputData( ) only copies specific hard-coded information to pipeline
DescriptionThe SetInputData( ) method relies on vtkTrivialProducer's FillOutputDataInformation( ) method to copy necessary information from the data object to the pipeline. Unfortunately, FillOutputDataInformation( ) is hard-coded to only copy certain information. For example, it has a hard-coded IsA("vtkImageData") check to see whether it should copy the SPACING and ORIGIN that are needed for vtkImageData.

Instead of having a hard-coded IsA( ) check, it should be delegating the task of copying the information to the data object, by calling a the following data object method (which doesn't yet exist):

    virtual CopyInformationToPipeline(vtkInformation* info);

In this way, each data object type can decide for itself what information should be copied. There is already a strong precedent for this, because copying the info in the other direction (from the pipeline to the data object) is done by a virtual method called CopyInformationFromPipeline( ). So CopyInformationToPipeline( ) will provide a very nice symmetry.

TagsNo tags attached.
ProjectTBD
Typefeature
Attached Files

 Relationships

  Notes
(0034280)
David Gobbi (developer)
2015-02-26 08:29

 http://review.source.kitware.com/#/t/5502/ [^]
(0035834)
David Gobbi (developer)
2016-03-07 18:06

 Was fixed in VTK 6.3 by commit a8a773be.

 Issue History
Date Modified Username Field Change
2015-02-25 00:42 David Gobbi New Issue
2015-02-25 00:42 David Gobbi Assigned To => David Gobbi
2015-02-25 22:51 David Gobbi Status backlog => active development
2015-02-26 08:29 David Gobbi Note Added: 0034280
2015-02-26 08:29 David Gobbi Status active development => gerrit review
2016-03-07 18:06 David Gobbi Note Added: 0035834
2016-03-07 18:06 David Gobbi Status gerrit review => closed
2016-03-07 18:06 David Gobbi Resolution open => fixed
2016-03-07 18:06 David Gobbi Fixed in Version => 6.3.0

Copyright © 2000 - 2018 MantisBT Team