View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0015002 | ParaView | (No Category) | public | 2014-09-18 17:59 | 2015-01-09 15:38 | ||||
Reporter | Utkarsh Ayachit | ||||||||
Assigned To | Utkarsh Ayachit | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | 4.2 | |||||||
Summary | 0015002: Catalyst failures when WriteImage is called on Line Plot View | ||||||||
Description | Catalyst failures when WriteImage is called on Line Plot View. The problem occurs when the line plot axes ranges change over time as the coprocessing proceeds. | ||||||||
Tags | No tags attached. | ||||||||
Project | LANL | ||||||||
Topic Name | chart_catalyst_fixes | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0033370) Utkarsh Ayachit (administrator) 2014-09-18 18:00 |
commit 84ef3991e27f095d56a2d02b3b8f13a30c2493c9 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Sep 18 11:19:52 2014 -0400 Fix chart representation being modified in render. vtkSMContextViewProxy was updating axes ranges at end of render which resulted in making the representation proxy modified. While this is not the end of the world in most cases, in symmetric batch mode, it can use the view proxy to be marked 'dirty' differently on ranks (since axes ranges never change on satellites. This hack, similar to what we do to handle updates for camera properties addresses that issue. We need a more gracefully support for such 'auto-updating' properties. Added a test would fail with "pvbatch -sym" without this fix. Change-Id: I18ae6c1efd5940855097f1ad8deeae527a0b846d commit 00cacc24bc7afa2edebc7c3bb850300ea54d54eb Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Sep 18 11:18:11 2014 -0400 Cleanup axes bounds computation in vtkPVXYChartView. vtkPVXYChartView doesn't need to compute axes bounds anywhere except after vtkPVXYChartView::Update(). That method gets called when any of the display properties or view properties change, or when data changes. Thus, that's the only place where we need to recompute the axes bounds. Change-Id: Id89559ca18c6f82f0e1029d044d0703697b3e24f commit b1ed1f848b659cf1f79784a1fcb65b8d6306b3eb Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Sep 18 11:15:36 2014 -0400 Cleanup when PrepareForRendering gets called. There's really no need to call PrepareForRendering on REQUEST_RENDER for a vtkChartRepresentation. vtkChartRepresentation will always receive a REQUEST_UPDATE when any of its properites (including display properties) or any of the view properties change. This, vtkChartRepresentation can get away with update vtkPlot and their properties in REQUEST_UPDATE itself. This avoid unnecessary work in rendering pass. Change-Id: I12133d185c8747de0999949cbc66aff9997cd456 commit 8e4ede85d180fd638b5c1f327dcce44b086ef52f Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Sep 18 16:32:10 2014 -0400 Fix missing render() on resetDisplay(). Change-Id: I42df17a03aa57acd29430ab3acc12c34afb45434 |
(0033371) Utkarsh Ayachit (administrator) 2014-09-18 18:32 |
back to active-development since it's causing dashboard issues. |
(0033372) Utkarsh Ayachit (administrator) 2014-09-18 22:00 |
commit 145efb6052f78c5205dc08ab1991b146fc58d1c4 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Sep 18 11:19:52 2014 -0400 Fix chart representation being modified in render. vtkSMContextViewProxy was updating axes ranges at end of render which resulted in making the representation proxy modified. While this is not the end of the world in most cases, in symmetric batch mode, it can use the view proxy to be marked 'dirty' differently on ranks (since axes ranges never change on satellites. This hack, similar to what we do to handle updates for camera properties addresses that issue. We need a more gracefully support for such 'auto-updating' properties. Added a test would fail with "pvbatch -sym" without this fix. Change-Id: I18ae6c1efd5940855097f1ad8deeae527a0b846d commit c2c0e8c5b8f2f62881579096f729071a6d3b6862 Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Sep 18 11:18:11 2014 -0400 Cleanup axes bounds computation in vtkPVXYChartView. vtkPVXYChartView doesn't need to compute axes bounds anywhere except after vtkPVXYChartView::Update(). That method gets called when any of the display properties or view properties change, or when data changes. Thus, that's the only place where we need to recompute the axes bounds. Change-Id: Id89559ca18c6f82f0e1029d044d0703697b3e24f commit 8e4ede85d180fd638b5c1f327dcce44b086ef52f Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Thu Sep 18 16:32:10 2014 -0400 Fix missing render() on resetDisplay(). Change-Id: I42df17a03aa57acd29430ab3acc12c34afb45434 |
(0033374) Utkarsh Ayachit (administrator) 2014-09-20 09:15 |
--------------------------------------------- Topics merged into master: chart_catalyst_fixes fix_static_plugins xdisplay_test_workaround |
(0034049) Alan Scott (manager) 2015-01-09 15:38 |
This is an old bug, and Utkarsh added a test to the dashboard. Closing untested. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2014-09-18 17:59 | Utkarsh Ayachit | New Issue | |
2014-09-18 18:00 | Utkarsh Ayachit | Topic Name | => chart_catalyst_fixes |
2014-09-18 18:00 | Utkarsh Ayachit | Note Added: 0033370 | |
2014-09-18 18:00 | Utkarsh Ayachit | Status | backlog => gatekeeper review |
2014-09-18 18:00 | Utkarsh Ayachit | Fixed in Version | => git-next |
2014-09-18 18:00 | Utkarsh Ayachit | Resolution | open => fixed |
2014-09-18 18:00 | Utkarsh Ayachit | Assigned To | => Utkarsh Ayachit |
2014-09-18 18:32 | Utkarsh Ayachit | Note Added: 0033371 | |
2014-09-18 18:32 | Utkarsh Ayachit | Status | gatekeeper review => active development |
2014-09-18 22:00 | Utkarsh Ayachit | Note Added: 0033372 | |
2014-09-18 22:37 | Utkarsh Ayachit | Status | active development => gatekeeper review |
2014-09-20 09:14 | Utkarsh Ayachit | Fixed in Version | git-next => git-master |
2014-09-20 09:15 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
2014-09-20 09:15 | Utkarsh Ayachit | Note Added: 0033374 | |
2014-09-24 10:13 | Utkarsh Ayachit | Fixed in Version | git-master => 4.2 |
2015-01-09 15:38 | Alan Scott | Note Added: 0034049 | |
2015-01-09 15:38 | Alan Scott | Status | customer review => closed |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |