View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014953ParaView(No Category)public2014-08-18 18:472015-09-06 12:18
ReporterKen Moreland 
Assigned ToUtkarsh Ayachit 
PrioritylowSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version4.4Fixed in Version4.4 
Summary0014953: Esc to clear text does not work in Settings dialog
DescriptionIn the settings dialog box, the search bar at the top when empty and not in focus has the instructions "Search ... (use Esc to clear text)" (similar to the search at the top of the properties. These instructions do not actually work with respect to hitting escape. When you hit escape, the dialog box closes.

I'm not sure what the right behavior here is, but I think it might be best to disable the behavior of closing the dialog box when you hit escape.
TagsNo tags attached.
ProjectTBD
Topic Name14953_fix_Esc_key_in_settings_dialog
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0034106)
Utkarsh Ayachit (administrator)
2015-01-23 10:46

 commit 525d86666261190a6485fd139ee7c4e474e2866d
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Jan 23 10:38:02 2015 -0500

    Fixed BUG 0014953. Properly handle Esc key in Search box.
    
    To fix BUG 0014953, we properly handle Esc key in the Search box.
    pqSearchBox now eats the Esc key if the Esc key will clear the text in
    the Search box and passes it only if the text box is already empty.
    Passing it through will cause the parent widget to do its default thing,
    e.g. closing of dialogs. As a result the Settings dialog now behaves as
    follows: when there is some text in the Search box, hitting Esc will clear it.
    If you hit Esc again (or when the Search box) is empty, the dialog does
    it's default thing, i.e it closes.
    
    Change-Id: I4b3c47f8056cf5f0311a9e96bda6a0c91173bb5d
(0034123)
Utkarsh Ayachit (administrator)
2015-01-29 08:06

 SUMMARY
---------------------------------------------
Topics merged into master (v4.3.1-83-gf35be3b):
        14953_fix_Esc_key_in_settings_dialog
        14957_fix_settings_segfault
        15031_fix_multicore_mode
        15283_fix_camera_settings_importation
        15293-guard-interactive-rendering
        bag-plot
        cosmotools-filters-xml
        fix_mpi_link_issues
(VTK) output-window-15240
(VTK) pvweb-loadsave-state-and-save-data
        pvweb-merge-sources-filters
(0034246)
Alan Scott (manager)
2015-02-18 17:29

 Tested local server, Linux, master.

 Issue History
Date Modified Username Field Change
2014-08-18 18:47 Ken Moreland New Issue
2014-09-09 11:02 Cory Quammen Target Version => 4.2
2014-11-14 22:52 Utkarsh Ayachit Target Version 4.2 => 4.4
2015-01-23 10:46 Utkarsh Ayachit Topic Name => 14953_fix_Esc_key_in_settings_dialog
2015-01-23 10:46 Utkarsh Ayachit Note Added: 0034106
2015-01-23 10:46 Utkarsh Ayachit Status backlog => gatekeeper review
2015-01-23 10:46 Utkarsh Ayachit Fixed in Version => git-next
2015-01-23 10:46 Utkarsh Ayachit Resolution open => fixed
2015-01-23 10:46 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2015-01-29 08:06 Utkarsh Ayachit Fixed in Version git-next => git-master
2015-01-29 08:06 Utkarsh Ayachit Status gatekeeper review => customer review
2015-01-29 08:06 Utkarsh Ayachit Note Added: 0034123
2015-02-18 17:29 Alan Scott Note Added: 0034246
2015-02-18 17:29 Alan Scott Status customer review => closed
2015-09-06 12:18 Utkarsh Ayachit Fixed in Version git-master => 4.4

Copyright © 2000 - 2018 MantisBT Team