(0032803)
Cory Quammen (developer)
2014-06-09 12:04

The underlying issue is that the proxy definition for the PythonView is available even when the class vtkSMPythonViewProxy.cxx is not included for compilation. vtkSMPythonViewProxy is conditionally included in the list of source files when PARAVIEW_ENABLE_MATPLOTLIB is enabled.

I think the solution is to separate out the definitions for the PythonView and PythonRepresentation into a separate XML file whose inclusion is conditioned on the value of PARAVIEW_ENABLE_MATPLOTLIB.

(0032804)
Utkarsh Ayachit (administrator)
2014-06-09 12:23

Note, you can add #ifdef in the xml files. Just make sure that vtkPVConfig has that definition.

At same time, I think PARAVIEW_ENABLE_MATPLOTLIB doesn't support the following use-case:

+ I build and installed ParaView
+ Next installed matplotlib -- ParaView matplotlib views don't start working. I need to rebuild PAraView.

We can punt on this use-case for now, but we should address it at some point.

(0032805)
Cory Quammen (developer)
2014-06-09 13:17

commit df2264d0ab1a755014efb5385a49f014e3f36427
Author: Cory Quammen <cory.quammen@kitware.com>
Date: Mon Jun 9 12:50:03 2014 -0400

    BUG 14787: Fixed error involving Python view

    When ParaView is compiled with the PARAVIEW_ENABLE_MATPLOTLIB option
    OFF, the XML for the Python view and representation are still
    included while the class definitions for the view and representation
    were not built or linked into the executable. This causes
    problems in servermanager.createModule(), which iterates over proxy
    XML definitions and attempts to create proxies defined in the XML.
    Specifically, when servermanager.createModule() tries to create a
    proxy for the python view, it fails because there is no instantiator
    for the Python view.

    Inclusion of the Python view and representation XML definitions
    conditioned on PARAVIEW_ENABLE_MATPLOTLIB fixes this problem.

    Change-Id: I29405016135c14f84c597e2abeab2cec565a548f

(0032816)
Utkarsh Ayachit (administrator)
2014-06-10 07:38

SUMMARY
---------------------------------------------
Topics merged into master:
        14762_save_color_legend_settings
        14787_fix_matplotlib_xml
        cleaning_point_sprite
        fix-transferfunction-applycolormap-text
        static-plugin-loading
(VTK) use-broadcast-rmi-trigger
        use-gatherv-in-collect-information

(0032827)
Alan Scott (manager)
2014-06-10 21:21

Pretty sure I get it. :-)

Tested Linux, master, without compiling in matplotlib. PythonView not available.

Issue History
Date Modified	Username	Field	Change
2014-06-07 12:42	Utkarsh Ayachit	New Issue
2014-06-07 12:42	Utkarsh Ayachit	Assigned To	=> Cory Quammen
2014-06-08 12:10	Utkarsh Ayachit	Relationship added	related to 0014548
2014-06-08 12:10	Utkarsh Ayachit	Priority	normal => high
2014-06-08 12:10	Utkarsh Ayachit	Target Version	=> 4.2
2014-06-09 12:04	Cory Quammen	Note Added: 0032803
2014-06-09 12:23	Utkarsh Ayachit	Note Added: 0032804
2014-06-09 13:17	Cory Quammen	Topic Name	=> 14787_fix_matplotlib_xml
2014-06-09 13:17	Cory Quammen	Note Added: 0032805
2014-06-09 13:17	Cory Quammen	Status	backlog => gatekeeper review
2014-06-09 13:17	Cory Quammen	Fixed in Version	=> git-next
2014-06-09 13:17	Cory Quammen	Resolution	open => fixed
2014-06-10 07:37	Utkarsh Ayachit	Fixed in Version	git-next => git-master
2014-06-10 07:38	Utkarsh Ayachit	Status	gatekeeper review => customer review
2014-06-10 07:38	Utkarsh Ayachit	Note Added: 0032816
2014-06-10 21:21	Alan Scott	Note Added: 0032827
2014-06-10 21:21	Alan Scott	Status	customer review => closed
2014-08-29 11:00	Utkarsh Ayachit	Fixed in Version	git-master => 4.2

Notes
(0032803) Cory Quammen (developer) 2014-06-09 12:04	The underlying issue is that the proxy definition for the PythonView is available even when the class vtkSMPythonViewProxy.cxx is not included for compilation. vtkSMPythonViewProxy is conditionally included in the list of source files when PARAVIEW_ENABLE_MATPLOTLIB is enabled. I think the solution is to separate out the definitions for the PythonView and PythonRepresentation into a separate XML file whose inclusion is conditioned on the value of PARAVIEW_ENABLE_MATPLOTLIB.

(0032804) Utkarsh Ayachit (administrator) 2014-06-09 12:23	Note, you can add #ifdef in the xml files. Just make sure that vtkPVConfig has that definition. At same time, I think PARAVIEW_ENABLE_MATPLOTLIB doesn't support the following use-case: + I build and installed ParaView + Next installed matplotlib -- ParaView matplotlib views don't start working. I need to rebuild PAraView. We can punt on this use-case for now, but we should address it at some point.

(0032805) Cory Quammen (developer) 2014-06-09 13:17	commit df2264d0ab1a755014efb5385a49f014e3f36427 Author: Cory Quammen <cory.quammen@kitware.com> Date: Mon Jun 9 12:50:03 2014 -0400 BUG 14787: Fixed error involving Python view When ParaView is compiled with the PARAVIEW_ENABLE_MATPLOTLIB option OFF, the XML for the Python view and representation are still included while the class definitions for the view and representation were not built or linked into the executable. This causes problems in servermanager.createModule(), which iterates over proxy XML definitions and attempts to create proxies defined in the XML. Specifically, when servermanager.createModule() tries to create a proxy for the python view, it fails because there is no instantiator for the Python view. Inclusion of the Python view and representation XML definitions conditioned on PARAVIEW_ENABLE_MATPLOTLIB fixes this problem. Change-Id: I29405016135c14f84c597e2abeab2cec565a548f

(0032816) Utkarsh Ayachit (administrator) 2014-06-10 07:38	SUMMARY --------------------------------------------- Topics merged into master: 14762_save_color_legend_settings 14787_fix_matplotlib_xml cleaning_point_sprite fix-transferfunction-applycolormap-text static-plugin-loading (VTK) use-broadcast-rmi-trigger use-gatherv-in-collect-information

(0032827) Alan Scott (manager) 2014-06-10 21:21	Pretty sure I get it. :-) Tested Linux, master, without compiling in matplotlib. PythonView not available.