View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014763 | ParaView | (No Category) | public | 2014-05-30 07:22 | 2014-08-29 11:00 | ||||
Reporter | Vadim SANDLER | ||||||||
Assigned To | Joachim Pouderoux | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | 4.1 | ||||||||
Target Version | 4.2 | Fixed in Version | 4.2 | ||||||
Summary | 0014763: Use platform dependant separator for the PV_PLUGIN_PATH environment variable | ||||||||
Description | The problem is that by some reason Paraview 4.1 only supports semicolon (";") as a separator of the directories for the PV_PLUGIN_PATH variable, though this is natural that separator is platform-dependant (";" on Windows and ":" on Linux). On the other hand ";" is used as a separator of the CMake list items and we encountered with the following problem: We have a CMake macro which accumulates an environment needed for the correct tests execution: GENERATE_TESTS_ENVIRONMENT(tests_env) ADD_TEST(TestName TestExecutable) SET_TESTS_PROPERTIES(TestName PROPERTIES ENVIRONMENT "${tests_env}") The variable tests_env is CMake list which contains a environment variables needed for the test execution: tests_env is "PATH=path1:path2:path3:...:pathn;LD_LIBRARY_PATH=ldpath1:ldpath2:ldpath3:...:ldpathn;PV_PLUGIN_PATH=pvpath1;pvpath2;pvpath3:...;pvpathn" The problem is that then CMake parses this list it takes for the PV_PLUGIN_PATH only fist path pvpath1 so far as ";" is a separator for the list items in CMake. Thus some tests fail because Paraview plug-ins located in the pvpath2, pvpath3,...,pvpathn can’t be found. Attached patch contains a small fix which allows use both ":" and ";" separators on Linux (to avoid possible regressions) and ";" separator on Windows for the PV_PLUGIN_PATH environment variable. Could you please analyze a patch and if possible integrate it the next version of the Paraview? | ||||||||
Tags | No tags attached. | ||||||||
Project | ParaViS | ||||||||
Topic Name | FixPluginPathSeparatorIssue | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | vtkPVPluginLoader.cxx.patch [^] (1,311 bytes) 2014-05-30 07:22 [Show Content] | ||||||||
Relationships | |
Relationships |
Notes | |
(0032752) Joachim Pouderoux (developer) 2014-06-05 11:20 |
Change I68767bce: Use platform dependant separator for the PV_PLUGIN_PATH env. var The problem is described in ticket 0014763. The problem is that by some reason Paraview 4.1 only supports semicolon (";") as a separator of the directories for the PV_PLUGIN_PATH variable, though this is natural that separator is platform-dependant (";" on Windows and ":" on Linux). On the other hand ";" is used as a separator of the CMake list items. Change-Id: I68767bce96fd6e8f8a4ae1cf33f01d62ccc7f336 |
(0032754) Joachim Pouderoux (developer) 2014-06-05 11:53 |
Merged to stage. |
(0032768) Utkarsh Ayachit (administrator) 2014-06-06 05:08 |
SUMMARY --------------------------------------------- Topics merged into master: 14573-deprecate-legacy-panels 14772_CTH_Tracers_on_by_default AddSideBySideHorizStereoModeToSaveDialogs FixGeometryFilterProxy FixPluginPathSeparatorIssue data-download-without-testing discretize_color manual-ParaViewData-option (VTK) refactor-piece-and-extent (VTK) refactor-piece-and-extent-2 static-plugins |
(0032835) Alan Scott (manager) 2014-06-10 21:55 |
Closing without testing. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2014-05-30 07:22 | Vadim SANDLER | New Issue | |
2014-05-30 07:22 | Vadim SANDLER | File Added: vtkPVPluginLoader.cxx.patch | |
2014-06-05 11:20 | Joachim Pouderoux | Note Added: 0032752 | |
2014-06-05 11:20 | Joachim Pouderoux | Assigned To | => Joachim Pouderoux |
2014-06-05 11:20 | Joachim Pouderoux | Status | backlog => active development |
2014-06-05 11:21 | Joachim Pouderoux | Topic Name | => FixPluginPathSeparatorIssue |
2014-06-05 11:53 | Joachim Pouderoux | Note Added: 0032754 | |
2014-06-05 11:53 | Joachim Pouderoux | Status | active development => gatekeeper review |
2014-06-05 11:53 | Joachim Pouderoux | Resolution | open => fixed |
2014-06-06 05:07 | Utkarsh Ayachit | Fixed in Version | => git-master |
2014-06-06 05:08 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
2014-06-06 05:08 | Utkarsh Ayachit | Note Added: 0032768 | |
2014-06-10 21:55 | Alan Scott | Note Added: 0032835 | |
2014-06-10 21:55 | Alan Scott | Status | customer review => closed |
2014-06-17 09:21 | Utkarsh Ayachit | Target Version | => 4.2 |
2014-08-29 11:00 | Utkarsh Ayachit | Fixed in Version | git-master => 4.2 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |