View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014737ParaView(No Category)public2014-05-18 14:592014-08-29 11:00
ReporterUtkarsh Ayachit 
Assigned Tojohan andruejol 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version4.2Fixed in Version4.2 
Summary0014737: Developer Tag: Create a custom widget for search box.
DescriptionThe "search" box on top of the "Properties" panel is a component widely repeated in ParaView. Currently, it's used in pqPropertiesPanel, pqColorMapEditor, pqSettingsDialog. We need to create a new custom widget that can be used in all these locations.

Ensure this widget can uniquely save/restore the state of the "advanced" button, if enabled by the developer. Also provide API whether to show the advanced button at all. This class should also handle the "Esc" to clear text properly.
TagsNo tags attached.
ProjectSandia
Topic Name14737-SearchBoxWidget
Typefeature
Attached Files

 Relationships

  Notes
(0032686)
johan andruejol (developer)
2014-05-29 14:24

 Topic ready for gerrit review here: http://review.source.kitware.com/#/t/4245/ [^]
(0032791)
Utkarsh Ayachit (administrator)
2014-06-09 07:19

 Johan,

Did this get merged in next/master again yet? I remember this was reverted from next due to dashboard issue (if i am not mistaken).
(0032797)
johan andruejol (developer)
2014-06-09 08:50

 I haven't merged it back again yet. I wanted to make sure it compiled fine on Unix and windows. It should be merged tomorrow.
(0032856)
Utkarsh Ayachit (administrator)
2014-06-12 11:00

 commit 5c9e6a861d863694e39e9d7f7c8de2603092b5b4
Author: Johan Andruejol <johan.andruejol@kitware.com>
Date: Wed Jun 11 10:56:10 2014 -0400

    Testing for the pqSearchBox
    
    Add a very basic test for the search box to make sure the basic interaction
    are here (Esc key and advanced button clickable).
    Fix all the QtTesting test that were influence by the factorization of the
    search to pqSearchBox.
    
    Change-Id: Ifc384e8bb3740ee2118585ee119265234c1bec9a

commit 6f9e4560531e3dfa9fe2f2c95f16ad2fd34b07b5
Author: Johan Andruejol <johan.andruejol@kitware.com>
Date: Wed May 28 09:56:14 2014 -0400

    Factorize the different search into one widget
    
    Multiple widgets were implementing their one search and with methods
    re-implement in each class. This is obviously difficult to maintain so all
    those search were factorize in this widget.
    The pqSeachDialog offers 2 main features:
     - If the user presses Esc, the search text is automatically cleared.
     - The advanced button can either: not be displayed, displayed normally
     or displayed and saved/restored as a setting
    
    Consequently replaced the searches in the appropriate widgets by the new
    pqSearchBox.
    
    Change-Id: I3e1560634566d6d207c2b1e86877df0b0261d38f
(0032873)
Utkarsh Ayachit (administrator)
2014-06-17 07:20

 Topics merged into master:
        14720-RemoveQtWebkit
        14737-SearchBoxWidget
        14799_optionally_hide_catalyst_inputs
        14803_remove_redundant_option
        bug_color_save_as_default
        fix_warnings
        misc_lut_fixes
(0032902)
Alan Scott (manager)
2014-06-18 22:18

 Superficially tested. Mainly trusting developers. Closing.

 Issue History
Date Modified Username Field Change
2014-05-18 14:59 Utkarsh Ayachit New Issue
2014-05-18 14:59 Utkarsh Ayachit Assigned To => johan andruejol
2014-05-28 09:42 johan andruejol Status backlog => active development
2014-05-29 14:24 johan andruejol Note Added: 0032686
2014-06-09 07:19 Utkarsh Ayachit Note Added: 0032791
2014-06-09 08:50 johan andruejol Note Added: 0032797
2014-06-12 11:00 Utkarsh Ayachit Topic Name => 14737-SearchBoxWidget
2014-06-12 11:00 Utkarsh Ayachit Note Added: 0032856
2014-06-12 11:00 Utkarsh Ayachit Status active development => gatekeeper review
2014-06-12 11:00 Utkarsh Ayachit Fixed in Version => git-next
2014-06-12 11:00 Utkarsh Ayachit Resolution open => fixed
2014-06-17 07:20 Utkarsh Ayachit Fixed in Version git-next => git-master
2014-06-17 07:20 Utkarsh Ayachit Note Added: 0032873
2014-06-17 07:28 Utkarsh Ayachit Status gatekeeper review => customer review
2014-06-17 09:21 Utkarsh Ayachit Target Version => 4.2
2014-06-18 22:18 Alan Scott Note Added: 0032902
2014-06-18 22:18 Alan Scott Status customer review => closed
2014-08-29 11:00 Utkarsh Ayachit Fixed in Version git-master => 4.2

Copyright © 2000 - 2018 MantisBT Team