View Issue Details Jump to Notes ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014557ParaView(No Category)public2014-02-04 20:452015-01-11 08:17
ReporterAlan Scott 
Assigned ToUtkarsh Ayachit 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version4.2Fixed in Version4.2 
Summary0014557: Color legend doesn't update properly
DescriptionMarking high, since this can misrepresent data. Must be fixed for 4.2.

Linux, master, local server.
Open can.exo. All vars on. Apply.
Color by EQPS. Color legend on. Show Color Editor.
Rescale to data range over all timesteps.

Do exactly as follows:
Click Yes. Don't move the mouse. Min and Max on EQPS has not changed.
Slowly move the mouse right, over the color legend. Color legend will update. This doesn't need clicking the Update icon. Either it should automatically update, or it should require clicking the Update icon.

If I had my preference, both Rescale to Data Range (on the toolbars and in the Color Map Editor) and Rescale to Data Range over All Timesteps would automatically apply.

This is a bug.
TagsNo tags attached.
ProjectSandia
Topic Name14557-color-legend-update
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0032314)
Utkarsh Ayachit (administrator)
2014-02-13 14:11

I agree. Both Rescale to Data Range (on the toolbars and in the Color Map Editor) and Rescale to Data Range over All Timesteps should automatically apply the changes.
(0032347)
Sankhesh Jhaveri (developer)
2014-02-18 19:46

Could not reproduce as of git-master@a001976f5
(0032369)
Utkarsh Ayachit (administrator)
2014-02-21 15:15

reopening since I can reproduce this (as can Alan).
(0032405)
Sankhesh Jhaveri (developer)
2014-02-25 15:13

commit 2aa1a16be66c3302e81cc0f1117305d451bd83e8
Author: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>
Date: Tue Feb 25 14:58:55 2014 -0500

    BUG: Render after rescaling color range
    
    This change fixes issue 14557(http://www.paraview.org/Bug/view.php?id=14557 [^])
    
    Change-Id: I0e4250840fee481153fad7cdd81be2d98e716121
(0032421)
Utkarsh Ayachit (administrator)
2014-02-27 11:29

Topics merged into master:
        14557-color-legend-update
(VTK) 14581-volume-render-bug
        14584-frequency-live-view
        14600-restore-numpy
        14602_fix_text_representation
        fix_mili
(0032517)
Alan Scott (manager)
2014-03-20 22:03

Nope, still wrong (although it is better). I missed one step. Note that the issue could be remote server, but i doubt it.


Linux, remote server, master.
Do exactly as follows:

* Open can.exo. All vars on. Apply.
* Forward one time step.
* Color by EQPS.
* Toggle Color Legend Visibility.
* Color Editor.
* Rescale to Data Range.
* On the Color editor, click on the second icon down from the top - the Rescale to Custom Range. Edit as Min -1 and Max 10. Rescale - AND DON'T MOVE YOUR MOUSE.

Now, slowly, move the mouse to the right, across the center of the Color Legend.

<<Bug - the color legend will magically update>>

Ask Utkarsh - I am tempted to say that Rescale to Custom Range should also be automatically applied, as are Rescale to Data Range and Rescale to Data Range across all timesteps.

(0032520)
Sankhesh Jhaveri (developer)
2014-03-21 10:11

commit 8202aa4a10073f49c4e08e70aeb00362c58e1946
Author: Sankhesh Jhaveri <sankhesh.jhaveri@kitware.com>
Date: Fri Mar 21 10:05:47 2014 -0400

    Render view automatically on rescale to custom range
    
    This change fixes issue 14557
    
    Change-Id: I625ceb578c087d80b9e9a4e037693a575a7d6b6d

 Qt/ApplicationComponents/pqColorOpacityEditorWidget.cxx | 3 +++
 1 file changed, 3 insertions(+)
(0032537)
Utkarsh Ayachit (administrator)
2014-03-28 11:55

---------------------------------------------
Topics merged into master:
        14557-color-legend-update
        14580-top-level-checkbox
(VTK) 14615-fix-mpi-segfault
        14650_check_bounds
        catalyst-web
        delaunay3d-alpha-bools
        fix_qt5_dashboard_failures
        pvweb-doc-update
(VTK) vtk_02_20_2014
        14632-find-data-query-combobo
(0032557)
Alan Scott (manager)
2014-04-08 19:44

Nope, still wrong. Please try all the combinations you can think of before moving to customer review. Here is the latest.


Linux, remote server, master.
Do exactly as follows:

* Open can.exo. All vars on. Apply.
* Forward one time step.
* Color by EQPS.
* Toggle Color Legend Visibility.
* Color Editor.
* Use log scale when mapping data to colors.

* Now, slowly move the mouse to the left, touching the color legend. It will redraw, taking into account the log. It should only redraw when you click update!!


(0032884)
Utkarsh Ayachit (administrator)
2014-06-17 09:32

Alan,

Unlike the "Properties" panel, the "Update" is not equivalent to "Apply". In other words, changes to this panel are "pushed" immediately. Hence the missing "Reset", since the changes have already been applied. "Update" simply triggers a render. Maybe this button should be renamed as "Render Views" or something like that, rather than calling it "Update"?
(0032890)
Alan Scott (manager)
2014-06-17 21:26

OK, I will agree - this is strange behavior, but correct behavior. The reason to not just always re-render is volume rendering. If a user is inserting a lot of points in the volume rendering control, you don't want ParaView frozen for each change. What do you think about changing the default to "auto apply"? If a user wants that off, they can change it...
(0032951)
Utkarsh Ayachit (administrator)
2014-06-27 15:47

commit 2159eb3f00d76b9018dc3066d5f0100350e78836
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Jun 27 15:45:20 2014 -0400

    BUG 0014557: Fixed updating on Color Map editor.
    
    + Renamed button as "Render Views" instead of "Update" to make it
    clearer what the button does.
    + Changed default to auto-update/auto-render all the view when LUT is
    changed.
    + Also added icon for Save as default to make the UI consistent with
    Properties panel.
    
    Change-Id: Ia69c6087de5c912cce8e21c422e309aa8bf1d031
(0032955)
Utkarsh Ayachit (administrator)
2014-06-30 08:24

SUMMARY
---------------------------------------------
Topics merged into master:
        14557-color-legend-update
(VTK) 14713_fix_lsdyna_reader
        14788-pqTextEdit
        14814_fix_cell_point_label_format
        14827_fix_paraview_module_requirements
        misc_quad_view_fixes

(0032982)
Alan Scott (manager)
2014-07-07 22:04

Waiting on an answer from Utkarsh, if we need a "restore state" button in the Color Map Editor. Otherwise, ready to close.
(0033123)
Alan Scott (manager)
2014-07-28 20:49

I wrote up "restore color map editor state" as bug 14845. Marking this one closed.

Tested Linux, master, remote server.

Nice!

 Issue History
Date Modified Username Field Change
2014-02-04 20:45 Alan Scott New Issue
2014-02-13 14:00 Utkarsh Ayachit Assigned To => Sankhesh Jhaveri
2014-02-13 14:00 Utkarsh Ayachit Status backlog => todo
2014-02-13 14:11 Utkarsh Ayachit Note Added: 0032314
2014-02-18 19:46 Sankhesh Jhaveri Note Added: 0032347
2014-02-18 19:46 Sankhesh Jhaveri Status todo => closed
2014-02-18 19:46 Sankhesh Jhaveri Resolution open => fixed
2014-02-18 19:46 Sankhesh Jhaveri Fixed in Version => git-master
2014-02-18 20:40 Utkarsh Ayachit Status closed => customer review
2014-02-21 15:15 Utkarsh Ayachit Note Added: 0032369
2014-02-21 15:15 Utkarsh Ayachit Status customer review => todo
2014-02-25 15:13 Sankhesh Jhaveri Topic Name => 14557-color-legend-update
2014-02-25 15:13 Sankhesh Jhaveri Note Added: 0032405
2014-02-25 15:13 Sankhesh Jhaveri Status todo => gatekeeper review
2014-02-27 11:29 Utkarsh Ayachit Status gatekeeper review => customer review
2014-02-27 11:29 Utkarsh Ayachit Note Added: 0032421
2014-03-20 22:03 Alan Scott Note Added: 0032517
2014-03-20 22:03 Alan Scott Status customer review => todo
2014-03-21 10:11 Sankhesh Jhaveri Note Added: 0032520
2014-03-21 10:11 Sankhesh Jhaveri Status todo => gatekeeper review
2014-03-28 11:55 Utkarsh Ayachit Status gatekeeper review => customer review
2014-03-28 11:55 Utkarsh Ayachit Note Added: 0032537
2014-04-08 19:44 Alan Scott Note Added: 0032557
2014-04-08 19:44 Alan Scott Status customer review => todo
2014-06-17 09:22 Utkarsh Ayachit Target Version => 4.2
2014-06-17 09:32 Utkarsh Ayachit Note Added: 0032884
2014-06-17 09:32 Utkarsh Ayachit Assigned To Sankhesh Jhaveri => Utkarsh Ayachit
2014-06-17 21:26 Alan Scott Note Added: 0032890
2014-06-27 15:47 Utkarsh Ayachit Note Added: 0032951
2014-06-27 15:47 Utkarsh Ayachit Status todo => gatekeeper review
2014-06-30 08:24 Utkarsh Ayachit Status gatekeeper review => customer review
2014-06-30 08:24 Utkarsh Ayachit Note Added: 0032955
2014-07-07 22:04 Alan Scott Note Added: 0032982
2014-07-28 20:49 Alan Scott Note Added: 0033123
2014-07-28 20:49 Alan Scott Status customer review => closed
2014-08-29 10:59 Utkarsh Ayachit Fixed in Version git-master => 4.2
2015-01-11 08:17 Utkarsh Ayachit Source_changeset_attached => ParaView master 4f41e2d5
2015-01-11 08:17 Utkarsh Ayachit Source_changeset_attached => ParaView master 2159eb3f


Copyright © 2000 - 2018 MantisBT Team