View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014522ParaView(No Category)public2014-01-16 16:582014-08-29 11:00
ReporterUtkarsh Ayachit 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version4.2Fixed in Version4.2 
Summary0014522: Clean properties panels for Charts
DescriptionProperties panels on charts currently use old style panels. These need to be updated. This will address the idiosyncrasies with these panels.
TagsNo tags attached.
ProjectSandia
Topic Namefix_chart_panels
Typeincorrect functionality
Attached Files

 Relationships
parent of 0013917closedUtkarsh Ayachit Plot selection over time doesn't work auto apply 
parent of 0013898closedKitware Robot Allow 2d to start with no variables turned on 

  Notes
(0032312)
Utkarsh Ayachit (administrator)
2014-02-13 11:56

 commit fee845bfc0790f62dfff3331025c6431b034bba3
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Feb 13 11:47:19 2014 -0500

    Disable render-server test for PlotOverTimeAutoApply.
    
    Since it uses surface selection which is not supported in render-server mode,
    disable PlotOverTimeAutoApply in that configuration.
    
    Change-Id: Ie8ee0150cd3d613e53e0a1e2b03ed552351d80e4

commit fb2e0a22ae7e062ab73e9cd215f0283faaf88a99
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Feb 13 11:22:19 2014 -0500

    BUG 0013773. Fixed auto-apply issues with plot-selection-over-time.
    
    pqSelectionInputWidget was setting up the default value for the selection input
    using a timer. That was happening after the auto-apply timer timed out. Thus,
    the apply would happen before the value was set, resulting in the default for
    the representation being setup incorrectly. That meant no data would be shown
    even the selection-input was setup immediately after when the timer expired.
    This fixes that issue by ensure that pqProxyPropertyWidget explicitly does the
    initialization and removing the timer logic from pqSelectionInputWidget.
    
    Also added a test to test this.
    
    Change-Id: I6b51801e362b0cbc9aec4a7a370db0b6f32adcb2

commit ce203cb7eb26550eb01ad4973d50b90c0a316d1c
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Feb 13 11:03:54 2014 -0500

    BUG: Fix errors in static builds.
    
    On static build dashboards, since StreamingParticles plugin is auto-loaded,
    ParaView was raising error when loading AMR datatsets.
    vtkStreamingParticlesRepresentation was incorrectly indicating that it can't
    support AMR datasets. Any representation added to "GeometryRepresentation" is
    required to support all datatypes that GeometryRepresentation supports. Fixed
    that.
    
    Change-Id: Ic17d25768c62ce634249259d016d7796fd18e71f

commit bb02ab64504da3474c50ccca9f537e7c20aafa9f
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Feb 11 23:53:47 2014 -0500

    Fix autoapply issue.
    
    AutoApply was starting separate singleShot(..) calls instead of using a
    single timer instance. This was causing weird issues on OsX with
    PlotSelectionOverTime when AutoApply was ON. Fixed that.
    
    Change-Id: Ic6917f301df0db75e194df7364b007d333dd2ae6

commit 0a020e8be91c0b7f3f330b29102b0f91baac4664
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Feb 11 12:05:15 2014 -0500

    Fixed more unused variable warnings.
    
    Change-Id: I19fe45f6857cc1201899981bba763e81dc663740

commit e39efad46b7ba896b744557caf63cc9a0987581d
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Feb 11 11:58:44 2014 -0500

    Fixed warnings with shadowed variables.
    
    Change-Id: I610e68c34134a589d25771a32fae55fdf0cc6b06

commit 11f833d9a62c707bba133d34e216a03dc8e79583
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Feb 11 09:46:50 2014 -0500

    Update test to potentially work better on Windows.
    
    We need to fix the trace recording/playback for pipeline browser to more
    reliable.
    
    Change-Id: I33ba0594031b9f86f705041702c264b2cfd77fbb

commit b3538a428c5abd5402cfc87fece845f27603932c
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Mon Feb 10 16:13:38 2014 -0500

    COMP: Fixed warnings
    
    Change-Id: Ief3f927ce032f38ef302237dc86d08d6729018e5

commit c6d017a45f4d9587ea56668a7145d5d4bb8186f1
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Mon Feb 10 16:00:38 2014 -0500

    Increase test thresholds.
    
    Change-Id: I4742b7ceeb9b671113cee57a20506c3622490b28

commit 11efa2246b116748be2631ddf1b311c303d79ab9
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Mon Feb 10 13:28:46 2014 -0500

    Add selection toggling context menu to pqSeriesEditorPropertyWidget.
    
    Change-Id: I885810872f13de7441dc527d6422bccf2b88983c

commit b80bc49c80c453f6cb4d13e36a4609093919f2a4
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Mon Feb 10 11:48:37 2014 -0500

    Make test playback a little more consistent.
    
    Change-Id: I9c174fd0161367496b7920f84a90e44a17e54be7

commit 8984354920d8b06b0a5865cdc72bfc0c0e03f47b
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Mon Feb 10 11:06:11 2014 -0500

    Fix LineChartSelection test.
    
    Change-Id: Ifcc151999dcf1e1a274a7637d73dcc136ec01ede

commit f3b3697d1b924038d05164dd32614851d989fd49
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Mon Feb 10 11:05:22 2014 -0500

    Fix interaction and locking of ranges.
    
    Charts were ignoreing interaction since on interaction the axes ranges were no
    locked. Fixed that. Lock axes ranges on interaction.
    
    Change-Id: I632850d6421ab3fdb4f0110dde7cbe6852103091

commit ca3eece086b04240ac2453b7febbf6e5b2b7b0f6
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sun Feb 9 18:33:39 2014 -0500

    Fix/Update tests after chart refactoring.
    
    Updating/Fixing tests. XYChart and XYHistogram tests have now been expanded to
    test some components of the display panel better, including composite datasets
    and changes in available arrays.
    
    Change-Id: Ic4ee83049ae13420f23101591e9b31db8c6f3139

commit bead7d4044f956db5615c8290681e336a50a20be
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sun Feb 9 18:32:08 2014 -0500

    Cleanup chart axis range reset logic.
    
    Every time the view is updated, we recalculate the chart axis ranges. The
    recalculation logic respects the case when user has "fixed" the axis range so
    it's not a problem to do this on every update. This ensures that over time and
    when new series are added/removed, the axis range is update automatically.
    
    Change-Id: I4a3a706ee391d62177f9211c7371325d580e6365

commit d485cfb912d5b5d5e71cb3c481ad6724a290d398
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sun Feb 9 18:31:03 2014 -0500

    Change color assignment logic.
    
    Make each vtkSMChartSeriesSelectionDomain instance pick its own instance of
    vtkColorSeries.
    
    Change-Id: I909e22d59cbb0751361d77e98f71deea78867b95

commit 4c50e35a84df2d810230351c101fc893bb3a0ce3
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sun Feb 9 16:52:27 2014 -0500

    Update pqSLACManager after chart changes.
    
    Updating pqSLACManager to use the new chart representations for setting up
    default values appropriately.
    
    Change-Id: I51134d1f97059eaa87b41824e007f5f077343654

commit b678de8f214fa0687470acaa92d55ab4f486b693
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sun Feb 9 16:19:24 2014 -0500

    BUG: vtkSMChartRepresentationProxy was chosing incorrect default.
    
    When known arrays were not available, vtkSMChartRepresentationProxy still
    erroneously chose to use the array instead of index due to a typo/copy-paste
    error. Fixed that.
    
    Change-Id: I174c5b3b449cd8f9e844478af724dd8fb9eebdaf

commit e8d21cef5501c1eb91b0f32119245ab8a6424ab6
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Feb 7 17:31:29 2014 -0500

    Remove unnecessary drag/drop overrides.
    
    They were added in past for supporting drag/drop in scatter plot. That code has
    been revised. Cleaning this up since I am not sure why this was needed in the
    first place.
    
    Change-Id: I8525ae7b17c5557a71d32608147b11ba490bbc9d

commit 85ce09f782011000321ab2eab2e6ede5204c7f35
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Feb 7 17:16:37 2014 -0500

    Enable multi-selection in pqSeriesEditorPropertyWidget.
    
    pqSeriesEditorPropertyWidget now allows users to select multiple rows and change
    series properties for all of them.
    
    Change-Id: Ic00566ba97207a554a71f9905cd0b7005e5a2571

commit c3ef157139a009b246140b3a9c0008ea599edd71
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Fri Feb 7 16:52:27 2014 -0500

    Fix segfault in comparative chart views.
    
    pqComparativeContextView was overriding appropriate methods on the superclass.
    Fixed that.
    
    Change-Id: I5fffe88792c8e0d57351f28449011de72d242ad7

commit 74a9a6e5a1278041d1eca17a7bc09a117e308cc9
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Feb 6 17:57:51 2014 -0500

    Add support for cases when series-domains change.
    
    When the domain for property with a vtkSMChartSeriesSelectionDomain changes, we
    need to update the property to reflect the change. This implementation handles
    it as follows:
    
    + vtkSMChartSeriesSelectionDomain has 'experimental' logic to update the
      property values to reflect the domain change.
    + pqSeriesEditorPropertyWidget uses a filtering mechanism to filter out rows for
      series that are not currently in domain to avoid the table from getting too big.
    + Also includes some cleanup to pqSMAdaptor to speed up certain 'get' calls.
    
    Change-Id: Iebbf9669d981bcd394d02b0fce588d88464950da

commit d36f8fd5669ebdae8955bfe35b36ed26c05c0b46
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Jan 2 14:29:33 2014 -0500

    Added auto-sizing QTableView subclass.
    
    Added a pqTableView which is a QTableView subclass that can resize its height
    based on the number of rows in it in an attempt to avoid to adding scroll bar
    for not too long a list of rows without always taking up space when there are
    fewer items in the table.
    
    Change-Id: I08223820d0e5a67ce75d5dc6c0c30b51fba69c1d

commit eeff246949c8306e457d2e87b15af11331d10fda
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Thu Jan 2 10:45:46 2014 -0500

    Cosmetic changes to pqSeriesEditorPropertyWidget.
    
    Avoid the ugly and fairly annoying horizontal scroll bar.
    Also changed row heights to add a little padding for better readability of text.
    
    Change-Id: Ia06de3e5a64b5f957357f40b580c1b3e215d9657

commit 678309078c95a3b3925f44f1cf1368f702efe27e
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Jan 1 16:23:32 2014 -0500

    Cleanup logic for setting default values.
    
    Added mechanism on vtkSMProxy to set default values for all properties that
    pqProxy now uses when a new proxy is created. We still have a few hacks lurking
    around for dealing with compound proxies in pqPipelineSource.
    
    Added support in vtkSMChartRepresentationProxy to correctly set UseIndexForXAxis
    property's default value based on what XArray is picked.
    
    Change-Id: If7e4ba6d40541e501a5524d2bbe55be8f992d646

commit a1cc509a3f19729e17d0e3ee496916d44b76f5c3
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Jan 1 13:39:17 2014 -0500

    Switching series widget to be a pqTreeView.
    
    pqTreeView is more compact than QTableView. Also fixed pqTreeView to avoid
    showing a vertical scroll bar for a configurable number of rows.
    
    Change-Id: Id0de77ede659e0df1f6b51179810c586c8fe1bd5

commit b8fb82758fc347b9d19750ee78ebb233fbd19a58
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sat Dec 28 17:19:18 2013 -0500

    Fixed issue with histogram display panel.
    
    The "X" array wasn't showing up correctly on the histogram panel. The problem
    was that pqStringVectorPropertyWidget didn't setup hooks to monitor the
    domain to update the available values in the combox-box. Fixed that.
    
    Change-Id: I3f2e08156ca99b4a9db2aca28a84897b1a109d3a

commit 1166c794ce339a569c7cf3503a6a23d311c21b86
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Tue Sep 3 18:25:05 2013 -0400

    Refactoring 2D chart representations.
    
    The primary objective of this refactor is to remove custom display panels for
    charting views such as line/bar/scatter-plot-matrix/parallel-coordinates views
    and migrate these panels to the new style as required by the unified Properties
    panel added in ParaView 4.0.
    
    The secondary object is to move logic for setting up defaults etc. to the
    ServerManager layer rather than in VTK or Qt world, so that the representations
    behave consistently in pvpython and ParaView-GUI.
    
    This is achieved as follows:
    
    + New domains are added (vtkSMChartSeriesListDomain and
      vtkSMChartSeriesSelectionDomain) which can be used on properties pertaining to
      series in a plot e.g. SeriesVisibility, SeriesColor etc. These domains
      automatically keep themselves up-to-date when new arrays are added or removed
      due to other state changes. Like other domains in ParaView, these only depend
      on the data-information available on the client-side.
    
    + vtkChartNamedOptions and vtkXYChartNamedOptions are removed. Instead
      vtkChartRepresentation subclasses take over the responsibility of managing
      series parameters. vtkXYChartRepresentation is suitable for vtkChartXY views
      which accept vtkPlot subclasses.
    
    + vtkChartRepresentation is refactored to simplify data-delivery logic. Also
      added a new REQUEST_RENDER pass to vtkPVContextView which allows chart
      representations to update the vtk objects properly thus separating data
      related operations from appearance related operations.
    
    + pqChartSeriesSettingsModel represent the table-widget used for presenting user
      with the available series and changing their properties. Based on properties
      available on the proxy, pqChartSeriesSettingsModel can adapt its UI to show as
      few or as many widgets as needed. pqChartSeriesSettingsModel is used for all
      2D views, thus we no longer need separate pqChartSeriesSettingsModel and
      pqPlotSettingsModel which have been removed.
    
    + vtkPVPlotMatrixRepresentation now respects order specified by the user on the
      SeriesVisibility property. The UI no longer hacks the order changes (which
      were not preserved in state files or undo/redo stacks), instead updates the
      property appropriately. Same can be done for
      vtkPVParallelCoordinatesRepresentation, but missing API on
      vtkPVParallelCoordinatesRepresentation keeps that from actually working, for
      now.
    
    + Refactored logic for dealing with multiblock-of-tables. The mechanism for
      naming/addressing tables in a multiblock dataset has also changed to make it
      easier to read. vtkChartRepresentation makes it easier for subclasses to work
      with multiblock of tables (e.g. vtkXYChartRepresentation) or a single
      vtkTable (vtkPVParallelCoordinatesRepresentation,
      vtkPVPlotMatrixRepresentation).
    
    A few side effects:
    
    + New arrays that become available are no longer shown automatically. The onus
      falls on the appplication layer to manage their visibility/appearance. Work in
      progress to update UI when new arrays become available.
    
    Change-Id: I6531f85a2167c73d98dbb28edf7aa3cc32031111

commit 42fb9819dae1b07004bfbe08774677938d161042
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sat Dec 28 02:30:37 2013 -0500

    Added mechanism to easily determine block-name.
    
    Added mechanism to vtkPVDataInformation to easily determine block name i.e. the
    vtkCompositeDataSet::NAME() for a block in a composite dataset.
    
    Change-Id: Iee25295d6fd4603f85c6b218cfff9cdc794209fb

commit 137344fcb6b64b3d61a8e59e3b10d7f40a09259c
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sat Dec 28 02:29:48 2013 -0500

    Remove unnecessary shallow copy.
    
    Minor cleanup, removed unnecessary shallow copy.
    
    Change-Id: I5e08407c50c9c3e543aaca3e7e487fc34f255293

commit 76b12864720ae41a7b064747574138f0386e51ce
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Sat Dec 28 02:28:42 2013 -0500

    vtkPVMergeTablesMultiBlock wrongly added empty tables to output.
    
    vtkPVMergeTablesMultiBlock ended up adding empty vtkTable instances to the
    output with a particular location was empty on all input composite datasets.
    Fixed that.
    
    Change-Id: I3e0aab158b3740f6f62ecdb0386af0bb30d682a8
(0032333)
Utkarsh Ayachit (administrator)
2014-02-15 08:58

 Topics merged into master:
        14511-qt5-support
        assembly-exporter
        catalyst-rendering-fix
        easy_subclassing
        fix_chart_panels
        fix_parallel_amrconnectivity
        remove_duplicate_pqColorTableModel
        robust_pca
        view-settings
        visit-bridge-update-2.7.0
(0032401)
Alan Scott (manager)
2014-02-24 13:02

 Tested Linux, local server, master. Looks nice - specifically the ability to plot multiple cells at at time.

 Issue History
Date Modified Username Field Change
2014-01-16 16:58 Utkarsh Ayachit New Issue
2014-01-16 16:58 Utkarsh Ayachit Relationship added parent of 0013917
2014-01-16 16:58 Utkarsh Ayachit Target Version => 4.2
2014-01-16 16:58 Utkarsh Ayachit Relationship added parent of 0013898
2014-02-07 21:48 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2014-02-07 21:48 Utkarsh Ayachit Status backlog => active development
2014-02-13 11:56 Utkarsh Ayachit Topic Name => fix_chart_panels
2014-02-13 11:56 Utkarsh Ayachit Note Added: 0032312
2014-02-13 11:56 Utkarsh Ayachit Status active development => gatekeeper review
2014-02-13 11:56 Utkarsh Ayachit Fixed in Version => git-next
2014-02-13 11:56 Utkarsh Ayachit Resolution open => fixed
2014-02-15 08:58 Utkarsh Ayachit Fixed in Version git-next => git-master
2014-02-15 08:58 Utkarsh Ayachit Status gatekeeper review => customer review
2014-02-15 08:58 Utkarsh Ayachit Note Added: 0032333
2014-02-24 13:02 Alan Scott Note Added: 0032401
2014-02-24 13:02 Alan Scott Status customer review => closed
2014-08-29 11:00 Utkarsh Ayachit Fixed in Version git-master => 4.2

Copyright © 2000 - 2018 MantisBT Team