View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0014418 | VTK | (No Category) | public | 2013-11-21 08:39 | 2015-01-09 13:36 | ||||
Reporter | jspricke | ||||||||
Assigned To | Sean McBride | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | 6.2.0 | |||||||
Summary | 0014418: VTK exports -Wno-deprecated through VTKConfig.cmake | ||||||||
Description | Hi, you are exporting compiler flags in CMake/VTKConfig.cmake.in (line 10-14). That's a bad idea most of the time, because projects using your libs import them automatically. For example I get a -Wno-deprecated from it (using the current Debian unstable packages (5.8.0-14.1), which means I don't get deprecation warnings for any of my code. I would propose to simply delete the mentioned lines. | ||||||||
Tags | No tags attached. | ||||||||
Project | TBD | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0032134) Sean McBride (developer) 2014-01-06 17:12 |
I tried changing the -Wno-deprecated to -Wdeprecated in CMake/vtkDetermineCompilerFlags.cmake and built on OS X 10.8 with VTK_LEGACY_REMOVE=OFF and did not see any warnings… May the suppression is indeed no longer necessary... |
(0032169) Sean McBride (developer) 2014-01-10 13:58 |
http://review.source.kitware.com/#/t/3833 [^] |
(0033392) Sean McBride (developer) 2014-10-01 10:54 |
jspricke, this should be fixed. Can you confirm? |
(0033393) jspricke (reporter) 2014-10-01 12:12 |
Looking at the code, it should be. As it's not part of a stable version, I haven't tested it. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2013-11-21 08:39 | jspricke | New Issue | |
2014-01-06 17:12 | Sean McBride | Note Added: 0032134 | |
2014-01-10 13:58 | Sean McBride | Note Added: 0032169 | |
2014-10-01 10:54 | Sean McBride | Note Added: 0033392 | |
2014-10-01 10:54 | Sean McBride | Assigned To | => Sean McBride |
2014-10-01 10:54 | Sean McBride | Status | backlog => tabled |
2014-10-01 10:54 | Sean McBride | Resolution | open => fixed |
2014-10-01 12:12 | jspricke | Note Added: 0033393 | |
2014-10-01 16:47 | Sean McBride | Status | tabled => closed |
2014-10-01 16:47 | Sean McBride | Fixed in Version | => 6.2.0 |
2015-01-09 13:36 | Sean McBride | Source_changeset_attached | => VTK master 8850b4d8 |
2015-01-09 13:36 | Sean McBride | Source_changeset_attached | => VTK master 9fd96021 |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |