View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014219ParaView(No Category)public2013-08-12 11:172013-11-01 13:18
ReporterSebastien Jourdain 
Assigned ToSebastien Jourdain 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version4.1 
Summary0014219: External plugins works only with parent plugin directory on Windows
DescriptionPARAVIEW_EXTERNAL_PLUGIN_DIRS expect a directory that contains ParaView plugins, but it is nice to also have a way to provide only one external plugin and properly support it.

This has been fixed in the following commit: stage/fix_cmake_external_plugin_macro

commit b817d6cd1aa01709762ccf3e769d49f034d6b8e6
Author: Sebastien Jourdain <sebastien.jourdain@kitware.com>
Date: Mon Aug 12 11:11:45 2013 -0400

    Fix PARAVIEW_EXTERNAL_PLUGIN_DIRS CMake Macro
    
    Allow PARAVIEW_EXTERNAL_PLUGIN_DIRS to be the Plugin directory
    and not only its parent. It use to work fine on Unix system
    as the double / was properly ingored but on Windows it will
    simply failed.
    
    Change-Id: Ia14830b3e2ed7f253e6b1a01977be4017b85a443

diff --git a/CMake/ParaViewPluginsMacros.cmake b/CMake/ParaViewPluginsMacros.cmake
index 5b0a1cd..f8549f1 100644
--- a/CMake/ParaViewPluginsMacros.cmake
+++ b/CMake/ParaViewPluginsMacros.cmake
@@ -136,7 +136,12 @@ macro(pv_plugin_search_under_root root_src root_build)
   file(GLOB_RECURSE files RELATIVE "${root_src}" "${root_src}/plugin.cmake")
   foreach(plugin_file IN LISTS files)
     get_filename_component(base "${plugin_file}" PATH)
- pv_add_plugin("${root_src}/${base}" plugin.cmake "${root_build}/${base}")
+ if(base)
+ pv_add_plugin("${root_src}/${base}" plugin.cmake "${root_build}/${base}")
+ else()
+ # The root directory is in fact the plugin directory
+ pv_add_plugin("${root_src}" plugin.cmake "${root_build}")
+ endif()
   endforeach()
 endmacro()
TagsNo tags attached.
ProjectTBD
Topic Namefix_cmake_external_plugin_macro
Typeincorrect functionality
Attached Files

 Relationships

  Notes
(0031480)
Utkarsh Ayachit (administrator)
2013-08-16 13:48

 Topics merged into master:
        0014218_fix_color_preset_issues
        13029_fix_auto_apply
        14158_fix_double_range_slider
        14185_fix_component_name
        14204_fix_domains
        14233_fix_disconnect_button
        14234_fix_trace_views
        better_disconnect_error_v2
        serverside_only_reader
(VTK) update_to_master
(0031600)
Alan Scott (manager)
2013-09-18 14:32

 I don't know how to test, will depend on Seb's testing.

 Issue History
Date Modified Username Field Change
2013-08-12 11:17 Sebastien Jourdain New Issue
2013-08-12 11:17 Sebastien Jourdain Assigned To => Sebastien Jourdain
2013-08-12 11:18 Sebastien Jourdain Topic Name => fix_cmake_external_plugin_macro
2013-08-12 11:18 Sebastien Jourdain Status backlog => gatekeeper review
2013-08-12 11:18 Sebastien Jourdain Resolution open => fixed
2013-08-16 13:48 Utkarsh Ayachit Fixed in Version => git-master
2013-08-16 13:48 Utkarsh Ayachit Status gatekeeper review => customer review
2013-08-16 13:48 Utkarsh Ayachit Note Added: 0031480
2013-09-18 14:32 Alan Scott Note Added: 0031600
2013-09-18 14:32 Alan Scott Status customer review => closed
2013-11-01 13:18 Utkarsh Ayachit Fixed in Version git-master => 4.1

Copyright © 2000 - 2018 MantisBT Team