View Issue Details [ Jump to Notes ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0014158ParaView(No Category)public2013-07-01 23:052015-01-11 08:24
ReporterUtkarsh Ayachit 
Assigned ToUtkarsh Ayachit 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version 
Target Version4.1Fixed in Version4.1 
Summary0014158: Update threshold panel to use double-ended slider
DescriptionUpdate threshold panel to use double-ended slider.

TagsNo tags attached.
ProjectSandia
Topic Name14158_fix_double_range_slider
Typefeature
Attached Files

 Relationships

  Notes
(0031114)
Utkarsh Ayachit (administrator)
2013-07-02 11:37

 commit 8107ac4f34730f949b8db912247e06aef4ae862c
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Mon Jul 1 23:05:54 2013 -0400

    BUG 0014158: Update threshold panel to use double-ended slider.
    
    Updating Threshold panel (i.e. pqDoubleRangeSliderPropertyWidget) to use double ended
    slider instead of two separate sliders. This overcomes wierd sync and update issues
    that were common with Threshold panel esp. on Macs.
    
    Change-Id: I2afad95c7d582a547c03974da9830554fe320f7c
(0031131)
Utkarsh Ayachit (administrator)
2013-07-12 14:07

 merged into master.
(0031427)
Alan Scott (manager)
2013-08-09 20:07

 Tested remote server, Linux, master.
(0031428)
Alan Scott (manager)
2013-08-09 20:13

 There is a bug in this implementation. Do the following:

Linux, master, remote server (I am sure local will show the bug).

* Open can.exo. Apply. Make sure you leave Time at 0.
* Threshold. Apply.
* Now, change to EQPS. The right slider disappears, and we are thresholding from 0 to 0. OK so far.
* Move forward one timestep.
<bug number 1> - part of the can gets thresholded. This shouldn't happen, right?

<bug number 2 (and the more important one)> - It is now impossible to find the max and min of EQPS. You can't find the right slider, and can't move the left one. This needs to be fixed.
(0031429)
Alan Scott (manager)
2013-08-09 20:13

 Moving to Todo (i.e., bad implementation, needing fixing), setting to Utkarsh, and increasing priority.
(0031450)
Utkarsh Ayachit (administrator)
2013-08-14 13:41
edited on: 2013-08-14 13:43

 <bug number 1> - part of the can gets thresholded. This shouldn't happen, right?

This is exactly as expected. If you show the original can and color by EQPS, you'll see that the thresholded cells had EQPS > 0 and hence they were removed by the filter.

<bug number 2> - is indeed a bug. looking into it.
(0031461)
Utkarsh Ayachit (administrator)
2013-08-14 22:57
edited on: 2013-08-14 22:58

 Alan,

Looking at bug #2, here's what's happening. The two sliders overlap on 0. Since the values set for min and max were 0, and for timestep 1 there's a non-zero range for EQPS, with 0 being the min, both the sliders end up over 0 as expected. Now to move the "max" slider, one can either click on the right-half of the slider or type text manually in the right-side entry box. Do similar on the left-half (or entry-box on the left side) to change the minimum.

Additionally, I am going to add ability to double click on the empty space on the slider to move the closest slider to that position, this making it possible to easily move the sliders when they overlap, as in this case.
(0031462)
Utkarsh Ayachit (administrator)
2013-08-14 23:01

 commit b530d0e0cdb97859d406f9e311759cdba6f5809e
Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Date: Wed Aug 14 22:56:29 2013 -0400

    BUG 0014158. Making it easier to move sliders when they overlap.
    
    When the min and max sliders overlap, it's very hard for the users to move them.
    To make that easier, added new ability to double click on the empty space on the
    slider widget to move the closest slider to that position. Thus, when the two
    sliders overlap, the user can double click on the left-side of the two sliders
    to move the min or right-side for the max slider.
    
    Change-Id: I24073cf403661434302ceaf2d7d0caa784f999e6
(0031473)
Utkarsh Ayachit (administrator)
2013-08-16 13:48

 Topics merged into master:
        0014218_fix_color_preset_issues
        13029_fix_auto_apply
        14158_fix_double_range_slider
        14185_fix_component_name
        14204_fix_domains
        14233_fix_disconnect_button
        14234_fix_trace_views
        better_disconnect_error_v2
        serverside_only_reader
(VTK) update_to_master
(0031529)
Alan Scott (manager)
2013-09-03 21:11

 I agree that bug number 1 isn't really a bug.

Bug 2 fixed. Tested Linux, master, remote server. Nice.

 Issue History
Date Modified Username Field Change
2013-07-01 23:05 Utkarsh Ayachit New Issue
2013-07-01 23:20 Utkarsh Ayachit Topic Name => 14158_update_threshold_panel
2013-07-01 23:20 Utkarsh Ayachit Type incorrect functionality => feature
2013-07-02 11:37 Utkarsh Ayachit Note Added: 0031114
2013-07-02 11:37 Utkarsh Ayachit Status backlog => gatekeeper review
2013-07-02 11:37 Utkarsh Ayachit Fixed in Version => git-next
2013-07-02 11:37 Utkarsh Ayachit Resolution open => fixed
2013-07-02 11:37 Utkarsh Ayachit Assigned To => Utkarsh Ayachit
2013-07-12 14:07 Utkarsh Ayachit Fixed in Version git-next => git-master
2013-07-12 14:07 Utkarsh Ayachit Status gatekeeper review => customer review
2013-07-12 14:07 Utkarsh Ayachit Note Added: 0031131
2013-08-09 20:07 Alan Scott Note Added: 0031427
2013-08-09 20:07 Alan Scott Status customer review => closed
2013-08-09 20:13 Alan Scott Note Added: 0031428
2013-08-09 20:13 Alan Scott Status closed => backlog
2013-08-09 20:13 Alan Scott Resolution fixed => reopened
2013-08-09 20:13 Alan Scott Note Added: 0031429
2013-08-09 20:13 Alan Scott Status backlog => todo
2013-08-09 20:14 Alan Scott Priority normal => high
2013-08-14 11:04 Utkarsh Ayachit Target Version => 4.1
2013-08-14 13:41 Utkarsh Ayachit Note Added: 0031450
2013-08-14 13:43 Utkarsh Ayachit Note Edited: 0031450
2013-08-14 22:57 Utkarsh Ayachit Note Added: 0031461
2013-08-14 22:58 Utkarsh Ayachit Note Edited: 0031461
2013-08-14 23:01 Utkarsh Ayachit Note Added: 0031462
2013-08-14 23:03 Utkarsh Ayachit Topic Name 14158_update_threshold_panel => 14158_fix_double_range_slider
2013-08-14 23:03 Utkarsh Ayachit Status todo => gatekeeper review
2013-08-14 23:03 Utkarsh Ayachit Resolution reopened => fixed
2013-08-16 13:48 Utkarsh Ayachit Status gatekeeper review => customer review
2013-08-16 13:48 Utkarsh Ayachit Note Added: 0031473
2013-09-03 21:11 Alan Scott Note Added: 0031529
2013-09-03 21:11 Alan Scott Status customer review => closed
2013-11-01 13:18 Utkarsh Ayachit Fixed in Version git-master => 4.1
2015-01-11 08:23 Cory Quammen Source_changeset_attached => ParaView master 2ea9c6ec
2015-01-11 08:24 Utkarsh Ayachit Source_changeset_attached => ParaView master e83e2ab5
2015-01-11 08:24 Utkarsh Ayachit Source_changeset_attached => ParaView master b530d0e0
2015-01-11 08:24 Sebastiennn Jourdain Source_changeset_attached => ParaView master f8315cfd
2015-01-11 08:24 Utkarsh Ayachit Source_changeset_attached => ParaView master 8107ac4f

Copyright © 2000 - 2018 MantisBT Team