View Issue Details [ Jump to Notes ] | [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0013965 | ParaView | (No Category) | public | 2013-03-23 02:30 | 2015-01-11 08:26 | ||||
Reporter | Utkarsh Ayachit | ||||||||
Assigned To | Utkarsh Ayachit | ||||||||
Priority | normal | Severity | minor | Reproducibility | have not tried | ||||
Status | closed | Resolution | fixed | ||||||
Platform | OS | OS Version | |||||||
Product Version | |||||||||
Target Version | Fixed in Version | 4.0 | |||||||
Summary | 0013965: Miscellaneous property panel issues | ||||||||
Description | (a) Properties being pushed prematurely: Attempt to change the opacity while typing, the values get updated as the user is typing. That's very bad as incorrect values can get pushed and also repeated renders can have performance issues. (b) "Apply" button goes green too frequently. Create Sphere source. Hit apply. Now click in "Center" property's 0th element. Hit tab without changing any value for a few times. Apply button will go green. It should not. Nothing has changed. (c) Large values show least insignificant digits. Create Sphere. Start typing 0.0012323234343 etc. for Center[0], the widget scrolls. Hit tab. Now the value you see some random digits. We should reposition the cursor to the beginning. (d) Apply button doesn't go green fast enough. Create Sphere. Hit Apply. Start typing something in "Radius". Apply button doesn't go green until the focus is lost and one hits "Enter". | ||||||||
Tags | No tags attached. | ||||||||
Project | TBD | ||||||||
Topic Name | misc_panel_fixes | ||||||||
Type | incorrect functionality | ||||||||
Attached Files | |||||||||
Relationships | |
Relationships |
Notes | |
(0030467) Utkarsh Ayachit (administrator) 2013-03-23 02:41 |
commit 146a6fae43ddaea042a465cdf7c7439ded0bbefd Author: Utkarsh Ayachit <utkarsh.ayachit@kitware.com> Date: Sat Mar 23 02:31:58 2013 -0400 BUG 0013965. Fixes plethora of panel usability issues. pqPropertyWidget now fires two signals: changeAvailable() and changeFinished(). pqPropertiesPanel uses changeAvailable() to mark Apply button green, while changeFinished() to call Apply (if auto-apply is ON) or push the value (for Display properties). Updated all pqPropertyWidget subclasses to respect this new protocol. This provides a clean distinction between when widgets say something is being changed/edited and something has been completely edited and ready to be processed. Using pqLineEdit instead of QLineEdit whereever relevant. Since pqLineEdit provides a textChangedAndEditingFinished() signal that can be used instead of editingFinished(), we can fire changeFinished() signals more reliable (not firing unless value was edited by the user) thus avoiding the bogus "Apply" bug. pqLineEdit also ensures that the most significant digits are always shown. Change-Id: I0ca10d56577d799791f29ecd7b4fe326064063a9 |
(0030471) Utkarsh Ayachit (administrator) 2013-03-24 11:21 |
SUMMARY --------------------------------------------- Topics merged into master: add_stereo_type_to_pvx (VTK) bgp_xlc_fixes fix_structured_volume_rendering misc_panel_fixes |
(0030495) Alan Scott (manager) 2013-04-02 18:55 |
Looks good. Tested Linux, master, local server. |
Notes |
Issue History | |||
Date Modified | Username | Field | Change |
2013-03-23 02:30 | Utkarsh Ayachit | New Issue | |
2013-03-23 02:33 | Utkarsh Ayachit | Description Updated | |
2013-03-23 02:41 | Utkarsh Ayachit | Topic Name | => misc_panel_fixes |
2013-03-23 02:41 | Utkarsh Ayachit | Note Added: 0030467 | |
2013-03-23 02:41 | Utkarsh Ayachit | Status | backlog => gatekeeper review |
2013-03-23 02:41 | Utkarsh Ayachit | Fixed in Version | => git-next |
2013-03-23 02:41 | Utkarsh Ayachit | Resolution | open => fixed |
2013-03-23 02:41 | Utkarsh Ayachit | Assigned To | => Utkarsh Ayachit |
2013-03-24 11:21 | Utkarsh Ayachit | Fixed in Version | git-next => git-master |
2013-03-24 11:21 | Utkarsh Ayachit | Status | gatekeeper review => customer review |
2013-03-24 11:21 | Utkarsh Ayachit | Note Added: 0030471 | |
2013-04-02 18:55 | Alan Scott | Note Added: 0030495 | |
2013-04-02 18:55 | Alan Scott | Status | customer review => closed |
2013-05-18 20:00 | Utkarsh Ayachit | Fixed in Version | git-master => 4.0 |
2015-01-11 08:26 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master 11c2fae9 |
2015-01-11 08:26 | Utkarsh Ayachit | Source_changeset_attached | => ParaView master 146a6fae |
Issue History |
Copyright © 2000 - 2018 MantisBT Team |