MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015634ParaView(No Category)public2015-08-10 22:112016-02-25 09:54
ReporterOrion Poplawski 
Assigned ToBen Boeckel (Kitware) 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version4.3 
Target VersionFixed in Version4.4 
ProjectTBD
Topic Nameremove-nektar
Typeincorrect functionality
Summary0015634: Non-free code in Paraview
DescriptionSee https://bugzilla.redhat.com/show_bug.cgi?id=1251289 [^]

Nektar plugin itself bundles:
Plugins/Nektar/Hlib: src subdir seems to contain a lot of non-free code (Copyright notice: This code shall not be replicated or used without the permission of the author.)

Plugins/SciberQuestToolKit: it seems to contain a lot of non-free code (opyright 2012 SciberQuest Inc.)

Also, I don't know how much Web/Widgets/NVCharts/paraview.nv.lineChart.js is based on NVD3, but if code is copied from it it should have better attribution/licensing than just:

// Provides implementation for a line-chart based on NVD3 (http://nvd3.org [^])
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-10 22:11Orion PoplawskiNew Issue
2015-08-31 16:25Utkarsh AyachitAssigned To => Ben Boeckel (Kitware)
2015-09-01 11:46Ben Boeckel (Kitware)Statusbacklog => active development
2015-09-01 11:47Ben Boeckel (Kitware)Topic Name => remove-nektar
2015-09-01 11:47Ben Boeckel (Kitware)Note Added: 0035113
2015-09-01 11:47Ben Boeckel (Kitware)Statusactive development => gatekeeper review
2015-09-01 11:47Ben Boeckel (Kitware)Fixed in Version => 4.4
2015-09-01 11:47Ben Boeckel (Kitware)Resolutionopen => fixed
2015-09-01 11:57Orion PoplawskiNote Added: 0035114
2015-09-01 13:10Ben Boeckel (Kitware)Note Added: 0035115
2015-09-01 14:02Orion PoplawskiNote Added: 0035116
2015-09-01 16:36Ben Boeckel (Kitware)Note Added: 0035117
2015-09-03 09:34Utkarsh AyachitNote Added: 0035154
2016-02-25 09:54Utkarsh AyachitStatusgatekeeper review => customer review
2016-02-25 09:54Utkarsh AyachitStatuscustomer review => closed

Notes
(0035113)
Ben Boeckel (Kitware)   
2015-09-01 11:47   
https://gitlab.kitware.com/paraview/paraview/merge_requests/346 [^]
(0035114)
Orion Poplawski   
2015-09-01 11:57   
At least from the description that tackled nektar. But what about the other concerns noted here?
(0035115)
Ben Boeckel (Kitware)   
2015-09-01 13:10   
They require emails to determine the status of them (basically get permission to change the license headers).
(0035116)
Orion Poplawski   
2015-09-01 14:02   
So that's still being worked on? I just saw the state being moved to "fixed" and worried that this was gong to be closed out. Thanks.
(0035117)
Ben Boeckel (Kitware)   
2015-09-01 16:36   
Mantis might be confusing here; the Status is "gatekeeper review". The other resolutions didn't make sense. Sorry for that.

As for updates, the Web/Widgets/NVCharts/paraview.nv.lineChart.js file, it uses nvd3; it is not a patched version.

Waiting for more info for SciberQuest.
(0035154)
Utkarsh Ayachit   
2015-09-03 09:34   
"remove_nektar" has been merged.

https://gitlab.kitware.com/paraview/paraview/merge_requests/346 [^]

Ben, please go ahead and add BSD headers to SciberQuest plugin and email Burlen for approval.