MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0014784ParaView(No Category)public2014-06-06 10:462014-08-29 10:59
ReporterAndy Bauer 
Assigned ToAndy Bauer 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version4.2Fixed in Version4.2 
ProjectCatalyst
Topic Name14784_PythonCatalyst_better_IO
Typeincorrect functionality
Summary0014784: vtkCPPythonScriptPipeline should have process 0 do as much work as possible and broadcast that to other processes
DescriptionOnly process 0 should check that the Python script exists and then read it in vtkCPPythonScriptPipeline. It can broadcast this information to the other processes to save on file IO.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-06-06 10:46Andy BauerNew Issue
2014-06-06 10:46Andy BauerAssigned To => Andy Bauer
2014-06-06 13:08Andy BauerStatusbacklog => todo
2014-06-06 13:08Andy BauerStatustodo => active development
2014-06-09 06:56Utkarsh AyachitTopic Name => 14784_PythonCatalyst_better_IO
2014-06-09 06:56Utkarsh AyachitNote Added: 0032785
2014-06-09 06:56Utkarsh AyachitStatusactive development => gatekeeper review
2014-06-09 06:56Utkarsh AyachitFixed in Version => git-next
2014-06-09 06:56Utkarsh AyachitResolutionopen => fixed
2014-06-09 06:57Utkarsh AyachitFixed in Versiongit-next => git-master
2014-06-09 07:01Utkarsh AyachitStatusgatekeeper review => customer review
2014-06-09 07:01Utkarsh AyachitNote Added: 0032788
2014-06-09 10:31Andy BauerNote Added: 0032801
2014-06-09 10:34Andy BauerNote Added: 0032802
2014-06-09 10:34Andy BauerStatuscustomer review => backlog
2014-06-09 10:34Andy BauerResolutionfixed => reopened
2014-06-09 10:34Andy BauerAssigned ToAndy Bauer => Utkarsh Ayachit
2014-06-09 15:21Andy BauerNote Added: 0032808
2014-06-17 09:21Utkarsh AyachitTarget Version => 4.2
2014-06-24 13:30Andy BauerAssigned ToUtkarsh Ayachit => Andy Bauer
2014-06-24 13:31Andy BauerStatusbacklog => todo
2014-07-14 09:39Andy BauerStatustodo => active development
2014-07-14 09:39Andy BauerNote Added: 0033014
2014-07-14 09:39Andy BauerStatusactive development => gatekeeper review
2014-07-14 09:39Andy BauerResolutionreopened => fixed
2014-07-14 10:07Utkarsh AyachitStatusgatekeeper review => customer review
2014-07-14 10:07Utkarsh AyachitNote Added: 0033016
2014-07-28 20:47Alan ScottNote Added: 0033122
2014-07-28 20:47Alan ScottStatuscustomer review => closed
2014-08-29 10:59Utkarsh AyachitFixed in Versiongit-master => 4.2

Notes
(0032785)
Utkarsh Ayachit   
2014-06-09 06:56   
fed7bb1 (stage/fix_cmake_warnings) Fix cmake warnings about mixed link types in target_links.
(0032788)
Utkarsh Ayachit   
2014-06-09 07:01   
SUMMARY
---------------------------------------------
Topics merged into master:
        14771_fix_global_annotation_filter
        14784_PythonCatalyst_better_IO
        fix_cmake_warnings
        fix_size_hint_pqTreeView
        misc_chart_panel_fixes
(0032801)
Andy Bauer   
2014-06-09 10:31   
commit 737ca0511a93ff9b3526b08694b55450bf8e84b7
Author: Andrew Bauer <andy.bauer@kitware.com>
Date: Fri Jun 6 13:05:41 2014 -0400

    Making only process 0 check if the Catalyst script exists.
    
    Process 0 now is the only process that checks whether a Catalyst
    Python script exists and then broadcasts that info to other
    processes. This is one less way we'll kill the file system
    when running at scale.
    
    Change-Id: I50fc220666d236c6d6f5f49eb89654168ac3e3d0
(0032802)
Andy Bauer   
2014-06-09 10:34   
The first commit only did a partial fix. That change had process 0 verify that the Python script existed and broadcast that information to the other processes. The next part is for process 0 to read in the script and broadcast that to the other processes. This could take a bit more care since there are edge cases that need to be tested.
(0032808)
Andy Bauer   
2014-06-09 15:21   
The next part that needs to be done is still in vtkCPPythonScriptPipeline. In Initialize() it should read in the script contents on process 0 and broadcast that string to the other processes. Then each process can do vtkPythonInterpreter::RunSimpleString(<file contents>) or something like that since it probably also needs to put the methods in that script in a namespace so that other Python script pipelines can be used without clashing. If the namespace is the name of the file without the path or extension then CoProcess() should be able to work without modifications.
(0033014)
Andy Bauer   
2014-07-14 09:39   
commit 0b163702c75914a7d4dcd22116c18dd16cbc0cf7
Author: Andrew Bauer <andy.bauer@kitware.com>
Date: Fri Jul 11 12:52:57 2014 -0400

    Windows fix for reading in the Catalyst Python script.
    
    Work done by Chuck Atkins so blame him if this doesn't work :).
    
    Change-Id: I36e6b52d6816f5a5a9a8d540ae3d1e2e3fdd55ff
(0033016)
Utkarsh Ayachit   
2014-07-14 10:07   
SUMMARY
---------------------------------------------
Topics merged into master:
        14784_PythonCatalyst_better_IO
(VTK) newest-xdmf
(0033122)
Alan Scott   
2014-07-28 20:47   
Developer tag in git. Closing.