MantisBT - VTK
View Issue Details
0013377VTK(No Category)public2012-08-20 14:452013-07-29 11:40
Utkarsh Ayachit 
Brad King 
normalminorhave not tried
closedfixed 
 
 
Kitware
incorrect functionality
0013377: SystemTools::EnableMSVCDebugHook using old environment variable.
SystemTools::EnableMSVCDebugHook() is still using the old DART environment variable to determine if we are running dashboard tests.

Ideally, we'd add support for the new DASHBOARD_TEST_FROM_CTEST variable.
No tags attached.
Issue History
2012-08-20 14:45Utkarsh AyachitNew Issue
2012-08-20 14:45Utkarsh AyachitStatusbacklog => tabled
2012-08-20 14:45Utkarsh AyachitAssigned To => Brad King
2012-08-20 14:48David ColeNote Added: 0029032
2012-08-20 16:37Brad KingNote Added: 0029033
2012-08-20 16:38Brad KingNote Edited: 0029033bug_revision_view_page.php?bugnote_id=29033#r463
2013-07-22 20:02Dave DeMarleStatustabled => backlog
2013-07-22 20:02Dave DeMarleNote Added: 0031245
2013-07-25 09:00Brad KingNote Added: 0031332
2013-07-29 11:39Brad KingStatusbacklog => active development
2013-07-29 11:39Brad KingNote Added: 0031360
2013-07-29 11:40Brad KingStatusactive development => closed
2013-07-29 11:40Brad KingResolutionopen => fixed

Notes
(0029032)
David Cole   
2012-08-20 14:48   
Both variables are set by ctest, and always will be for backwards compatibility.
(0029033)
Brad King   
2012-08-20 16:37   
(edited on: 2012-08-20 16:38)
Try this patch:

diff --git a/Utilities/KWSys/vtksys/SystemTools.cxx b/Utilities/KWSys/vtksys/SystemTools.cxx
index 66850e9..4fd2c04 100644
--- a/Utilities/KWSys/vtksys/SystemTools.cxx
+++ b/Utilities/KWSys/vtksys/SystemTools.cxx
@@ -4841,7 +4841,8 @@ static int SystemToolsDebugReport(int, char* message, int*)
 
 void SystemTools::EnableMSVCDebugHook()
 {
-  if (getenv("DART_TEST_FROM_DART"))
+  if (getenv("DART_TEST_FROM_DART") ||
+      getenv("DASHBOARD_TEST_FROM_CTEST"))
     {
     _CrtSetReportHook(SystemToolsDebugReport);
     }


(0031245)
Dave DeMarle   
2013-07-22 20:02   
moving all "tabled" bugs into "backlog" category since "tabled" is no longer used.
(0031332)
Brad King   
2013-07-25 09:00   
Patch from 0013377:0029033 applied to upstream KWSys:

 http://public.kitware.com/gitweb?p=KWSys.git;a=commitdiff;h=e39f85e0 [^]
(0031360)
Brad King   
2013-07-29 11:39   
KWSys change from 0013377:0031332 imported to VTK:

 http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=196cc337 [^]