MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013130ParaView(No Category)public2012-04-25 14:412015-09-03 05:41
ReporterAlan Scott 
Assigned ToCory Quammen 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version3.14 
Target Version4.4Fixed in Version4.4 
ProjectSandia
Topic Name13130_fix_scalar_bar_settings
Typefeature
Summary0013130: color legend layout should allow manual control
DescriptionWe need to add the ability to manually set the color legend to be horizontal or vertical. Currently this is automatic, which is problematic if you need numerous, horizontal color legends on the right side of the screen.
Steps To Reproduce
Additional Information
TagsColorMap
Relationships
related to 0015629closed Utkarsh Ayachit Need option to have color legend placement be sticky 
has duplicate 0015434closed Mathieu Westphal Feature: Define default orientation of the 'Color Map' in the ParaView settings 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-25 14:41Alan ScottNew Issue
2013-07-26 12:35Utkarsh AyachitTag Attached: ColorMap
2014-01-16 17:05Utkarsh AyachitTarget Version => 4.2
2014-11-14 22:52Utkarsh AyachitTarget Version4.2 => 4.4
2015-06-08 14:29Utkarsh AyachitAssigned To => David C. Lonie
2015-06-08 14:29Utkarsh AyachitStatusbacklog => todo
2015-07-07 22:23Alan ScottNote Added: 0034686
2015-07-08 16:30Utkarsh AyachitStatustodo => backlog
2015-07-08 16:36Utkarsh AyachitStatusbacklog => todo
2015-07-14 13:20David C. LonieNote Added: 0034775
2015-07-14 13:20David C. LonieStatustodo => active development
2015-07-14 13:20David C. LonieStatusactive development => gatekeeper review
2015-07-14 13:20David C. LonieResolutionopen => fixed
2015-07-27 11:27Utkarsh AyachitNote Added: 0034825
2015-07-27 11:27Utkarsh AyachitStatusgatekeeper review => customer review
2015-07-27 11:27Utkarsh AyachitFixed in Version => git-master
2015-07-27 18:11Alan ScottNote Added: 0034828
2015-07-27 18:11Alan ScottStatuscustomer review => todo
2015-07-28 09:59David C. LonieNote Added: 0034845
2015-07-28 10:00David C. LonieAssigned ToDavid C. Lonie => Utkarsh Ayachit
2015-08-10 11:11Utkarsh AyachitAssigned ToUtkarsh Ayachit => Cory Quammen
2015-08-10 11:12Utkarsh AyachitNote Added: 0034937
2015-08-10 18:31Utkarsh AyachitAssigned ToCory Quammen => David C. Lonie
2015-08-11 08:53David C. LonieNote Added: 0034938
2015-08-11 11:15Utkarsh AyachitRelationship addedrelated to 0015629
2015-08-11 11:15Utkarsh AyachitNote Added: 0034940
2015-08-11 11:15Utkarsh AyachitStatustodo => customer review
2015-08-11 18:02Alan ScottNote Added: 0034962
2015-08-11 18:02Alan ScottStatuscustomer review => todo
2015-08-13 16:58Cory QuammenNote Added: 0034993
2015-08-14 10:54Cory QuammenAssigned ToDavid C. Lonie => Cory Quammen
2015-08-14 10:54Cory QuammenStatustodo => active development
2015-08-15 09:31Cory QuammenTopic Name => 13130_fix_scalar_bar_settings
2015-08-15 09:31Cory QuammenNote Added: 0034998
2015-08-15 09:31Cory QuammenStatusactive development => gatekeeper review
2015-08-15 09:31Cory QuammenFixed in Versiongit-master => 4.4
2015-08-18 23:49Cory QuammenNote Added: 0035025
2015-08-19 08:09Utkarsh AyachitNote Added: 0035027
2015-08-19 08:09Utkarsh AyachitStatusgatekeeper review => customer review
2015-09-02 16:53Alan ScottNote Added: 0035137
2015-09-02 16:53Alan ScottStatuscustomer review => closed
2015-09-03 05:41Mathieu WestphalRelationship addedhas duplicate 0015434

Notes
(0034686)
Alan Scott   
2015-07-07 22:23   
Note that the use case my user has given is as follows: Split view horizontal. Split each view vertically. Please the can in each of these 4 views. Paint by something (Vel). Now, try to change each color legend to be full height, right side of the views. Make them exactly the same size. Increase the annotation/label text size.
(0034775)
David C. Lonie   
2015-07-14 13:20   
Pull requests are in:

VTK: https://gitlab.kitware.com/vtk/vtk/merge_requests/423 [^]
PV: https://gitlab.kitware.com/paraview/paraview/merge_requests/221 [^]
(0034825)
Utkarsh Ayachit   
2015-07-27 11:27   
The Edit Color Legent Paramemeters now has checkbox that can be used to decide whether auto-orientation is to be used. If unchecked, user can override how the color legend should be oriented.
(0034828)
Alan Scott   
2015-07-27 18:11   
I don't think this works well at all. Here is how I tested:

* Linux, master, local server.
* Delete your .config files, don't run -dr
* Open can.exo. All vars on. Apply.
* Color by ACCL.
* Edit Color Map, which brings up the Edit Map Color. (As an asside, please make these the same. You don't Edit Color Map to bring up the Edit Map Color dialog!)
* Edit Color Legend Properties. Unselect Auto Orient. Orientation Horizontal. Apply.
* Save Current settings values as default. Now, say OK.
<<Bug>> - the horizontal color legend is half cut off, off the lower right of the screen. For horizontal, please center it.
* Close ParaView. Open ParaView.
* Open can.exo. All vars on. Apply.
* Color by ACCL.
<<Bug>> - The color legend is vertical. We didn't save the current settings as default.
* Edit Color Legend Properties. Unselect Auto Orient. Orientation Horizontal. Apply.
* Save Current settings values as default. Now, say OK.
* Split screen horizontal. Make the can visible. Color by ACCL.
<<Bug>> - We get the following error:

ERROR: In /projects/viz/paraview/src/ParaView/4.4.0-junk2/ParaView4/VTK/Rendering/Core/vtkCoordinate.cxx, line 351
vtkCoordinate (0x7c26c30): Request for coordinate transformation without required viewport


ERROR: In /projects/viz/paraview/src/ParaView/4.4.0-junk2/ParaView4/VTK/Rendering/Core/vtkCoordinate.cxx, line 351
vtkCoordinate (0x7c26e30): Request for coordinate transformation without required viewport

<<Bug>> - The color legend is vertical!
(0034845)
David C. Lonie   
2015-07-28 09:59   
Reassigning to Utkarsh, he's got some plans for these issues.

BTW, this patch fixes the vtkCoordinate warnings:

--- Interaction/Widgets/vtkBorderRepresentation.cxx
+++ Interaction/Widgets/vtkBorderRepresentation.cxx
@@ -471,9 +471,10 @@ void vtkBorderRepresentation::UpdateShowBorder()
 //-------------------------------------------------------------------------
 void vtkBorderRepresentation::BuildRepresentation()
 {
- if ( this->GetMTime() > this->BuildTime ||
- (this->Renderer && this->Renderer->GetVTKWindow() &&
- this->Renderer->GetVTKWindow()->GetMTime() > this->BuildTime) )
+ if (this->Renderer &&
+ (this->GetMTime() > this->BuildTime ||
+ (this->Renderer->GetVTKWindow() &&
+ this->Renderer->GetVTKWindow()->GetMTime() > this->BuildTime)))
     {
     // Negotiate with subclasses
     if ( ! this->Negotiated )
(0034937)
Utkarsh Ayachit   
2015-08-10 11:12   
Cory, Mind taking care of the warning message? Thanks
(0034938)
David C. Lonie   
2015-08-11 08:53   
Warning PR is up:

VTK: https://gitlab.kitware.com/vtk/vtk/merge_requests/519 [^]
PV: https://gitlab.kitware.com/paraview/paraview/merge_requests/293 [^]
(0034940)
Utkarsh Ayachit   
2015-08-11 11:15   
The warning has been fixed.

BUG 0015629 has been reported for the stickness issue.
(0034962)
Alan Scott   
2015-08-11 18:02   
Nope, this still doesn't work correctly. See my long note, see the <<bug>> sections. Basically, it doesn't remember legend layout between sessions, even though it was told to. Main example is to remember horizontal layout of the color legend.
(0034993)
Cory Quammen   
2015-08-13 16:58   
Regarding the Orientation not being restored from settings:

The Orientation property of the ScalarBarRepresentation has an information property. As such, when vtkSMParaViewPipelineController::PostInitializeProxy() goes to reset the value to the domain defaults, the value of the information property (which is the current value of the orientation) is set as the orientation value. This should be fixable by adding a <NoDefault /> hint to the orientation property.
(0034998)
Cory Quammen   
2015-08-15 09:31   
https://gitlab.kitware.com/paraview/paraview/merge_requests/301 [^]

commit 97d854b224bc0fd4bfa29b5d172f16323496f59d
Author: Cory Quammen <cory.quammen@kitware.com>
Date: Sat Aug 15 09:19:33 2015 -0400

    BUG: 13130 fixed scalar bar settings
    
    The AutoOrient and Orientation seetetings were not being restored from
    the settings file. Since these have an information property, they were
    being reset to the value of the information property. Added a
    <NoDefault /> hint to stop this from happening.
    
    Also, changed the position of scalar bars oriented horizontally
    when they are initially added to keep them in the view.
(0035025)
Cory Quammen   
2015-08-18 23:49   
This change has been merged into master.
(0035027)
Utkarsh Ayachit   
2015-08-19 08:09   
The "warning" fix is in VTK, it will be brought into ParaView when we update the VTK reference (which should be soon).
(0035137)
Alan Scott   
2015-09-02 16:53   
Yep, this is fixed correctly. Note that when the color legend originally moved from vertical to horizontal, it was cut off. That's probably OK. After that, ParaView correctly placed it on the screen.

Tested local server, Linux, master. Used my (long winded) testing notes above.