MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0013096ParaViewFeaturepublic2012-04-13 11:162016-08-12 09:59
ReporterIan Curington 
Assigned ToKitware Robot 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionmoved 
PlatformOSOS Version
Product Version3.14.1 
Target VersionFixed in Version 
ProjectParaViewPro
Topic Name
Typeincorrect functionality
Summary0013096: Fix Cancel action on Fix Path in State Files dialog
DescriptionPROBLEM:
Cancel of data path dialog continues to load possibly incorrect data paths.

SOLUTION:
Add canceling of entire loading of state file after clicking on 'X' or 'Cancel' button in "Fix Paths in State Files" dialog.

   patched files: pqApplicationCore.[h, cxx], pqFixPathsInStateFilesBehavior.cxx
   action: copy pqApplicationCore.* to ParaView-3.14.0/Qt/Core
           copy pqFixPathsInStateFilesBehavior.cxx to ParaView-3.14.0/Qt/ApplicationComponents

    DESCRIPTION: When user loads state file with filenames specified in it, dialog pops up to allow user to update filenames
    paths. In case user clicks on Cancel or 'X' button, patch allows stopping entire process of loading of state files, instead of
    stopping only fixing pathnames in state file being loaded as it was previously done. Perhaps previous behavior was intended
    feature, but canceling of entire loading process when user clicks on 'X' or 'Cancel' looks much more natural than continuing with
    loading of state file.

    CHANGES: To make this patch, following changes were made (ParaView source patch):

        - Added QuitLoadingStateFile property and its mutator to pqApplicationCore class,
        - Added logic of quiting loading of state file in case flag is set in pqApplicationCore::loadStateFile() routine,
        - Added setting of pqApplicationCore::QuitLoadingStateFile flag in pqFixPathsInStateFilesBehavior class.



Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files? pqApplicationCore.h (13,622) 2012-04-13 11:16
https://www.vtk.org/Bug/file/9173/pqApplicationCore.h
cxx pqApplicationCore.cxx (27,396) 2012-04-13 11:17
https://www.vtk.org/Bug/file/9174/pqApplicationCore.cxx
cxx pqFixPathsInStateFilesBehavior.cxx (3,333) 2012-04-13 11:18
https://www.vtk.org/Bug/file/9175/pqFixPathsInStateFilesBehavior.cxx
Issue History
Date ModifiedUsernameFieldChange
2012-04-13 11:16Ian CuringtonNew Issue
2012-04-13 11:16Ian CuringtonFile Added: pqApplicationCore.h
2012-04-13 11:17Ian CuringtonFile Added: pqApplicationCore.cxx
2012-04-13 11:18Ian CuringtonFile Added: pqFixPathsInStateFilesBehavior.cxx
2012-04-23 10:36Utkarsh AyachitNote Added: 0028514
2012-04-23 10:36Utkarsh AyachitCategory(No Category) => Feature
2012-04-23 10:41Utkarsh AyachitProjectTBD => ParaViewPro
2012-05-14 05:14Nenad VujicicNote Added: 0028600
2016-08-12 09:59Kitware RobotNote Added: 0038192
2016-08-12 09:59Kitware RobotStatusbacklog => closed
2016-08-12 09:59Kitware RobotResolutionopen => moved
2016-08-12 09:59Kitware RobotAssigned To => Kitware Robot

Notes
(0028514)
Utkarsh Ayachit   
2012-04-23 10:36   
I'd propose removing the "Cancel" button all together.
(0028600)
Nenad Vujicic   
2012-05-14 05:14   
Dear Utkarsh,

We think it would be great if we could have cancellation mechanism like Cancel or 'X' button. It would help us in cases we make mistake and start loading wrong state file or would like to prepare input in a different way.

If You don't have some particular reasons for removing it, can You please keep Cancel and 'X' buttons?

Best regards,
Nenad.
(0038192)
Kitware Robot   
2016-08-12 09:59   
Resolving issue as `moved`.

This issue tracker is no longer used. Further discussion of this issue may take place in the current ParaView Issues page linked in the banner at the top of this page.