MantisBT - VTK
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0012693VTK(No Category)public2011-11-01 04:532014-01-27 07:32
ReporterAndreas Buykx 
Assigned ToDavid Partyka 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Version5.8.0 
Target Version5.8.1Fixed in Version 
ProjectTBD
Typeincorrect functionality
Summary0012693: vtkMPASReader.cxx defines global variable PI
Descriptionvtk-5.8.0-source/IO/vtkMPASReader.cxx, line 104 defines a global variable PI.
double PI = 3.141592;

This global variable (of very limited precision) can easily clash with other definitions of PI, as in our case with a global PI in OpenCascade. This can easily lead to very hard to detect bugs: we spent roughly 5 man days until we found this ...

It looks like the variable declaration can safely be changed into a static declaration, hiding the variable from the global namespace.
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-01 04:53Andreas BuykxNew Issue
2011-11-01 08:48David PartykaAssigned To => David Partyka
2011-11-01 08:48David PartykaStatusbacklog => tabled
2011-11-01 08:49David PartykaTarget Version => 5.8.1
2011-11-04 15:53Sean McBrideNote Added: 0027660
2011-11-08 15:08Sean McBrideNote Added: 0027671
2011-11-08 16:00Sean McBrideSource_changeset_attached => VTK master 70fa8325
2011-11-08 16:00Sean McBrideSource_changeset_attached => VTK master f3a01308
2011-11-11 16:00Utkarsh AyachitSource_changeset_attached => VTK master 1802e01c
2013-07-22 20:03Dave DeMarleStatustabled => backlog
2013-07-22 20:03Dave DeMarleNote Added: 0031264
2013-07-22 20:33Dave DeMarleStatusbacklog => expired
2013-07-22 20:33Dave DeMarleNote Added: 0031279
2014-01-27 07:32Andreas BuykxNote Added: 0032222
2014-01-27 07:32Andreas BuykxStatusexpired => closed
2014-01-27 07:32Andreas BuykxResolutionopen => fixed

Notes
(0027660)
Sean McBride   
2011-11-04 15:53   
http://review.source.kitware.com/3207 [^]
(0027671)
Sean McBride   
2011-11-08 15:08   
This is now fixed in git master.
(0031264)
Dave DeMarle   
2013-07-22 20:03   
moving all "tabled" bugs into "backlog" category since "tabled" is no longer used.
(0031279)
Dave DeMarle   
2013-07-22 20:33   
Dave P no longer works on the project. If these old issues still exist in 6.0.0, reopen them and assign to Dave DeMarle
(0032222)
Andreas Buykx   
2014-01-27 07:32   
Code review of 6.1.0: no PI found in header anymore. Issue can be closed as far as I'm concerned.