MantisBT - ParaView
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0015399ParaView(No Category)public2015-03-26 21:242015-11-04 21:27
ReporterAlan Scott 
Assigned ToUtkarsh Ayachit 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOSOS Version
Product Versiongit-master 
Target Version5.1Fixed in Version4.4 
ProjectSandia
Topic Name
Typeperformance
Summary0015399: Exodus modeshapes performance work
DescriptionHere are two files that improve the performance of Exodus modeshapes (and all Exodus to a lesser extent).

Do not apply the ncx.c file without asking me and Utkarsh and/or Ken. This code is actually auto generated, so shouldn't be edited in this file...
Steps To Reproduce
Additional Information
TagsNo tags attached.
Relationships
related to 0015394closed Alan Scott ParaView performance is poor, unstructured grid 
related to 0015566closed Utkarsh Ayachit ncx.c performance work 
related to 0015568closed Utkarsh Ayachit Master performance work from Alan 
Attached Filesdiff vtkExodusIIReader.cxx.diff (6,856) 2015-07-06 21:28
https://www.vtk.org/Bug/file/9835/vtkExodusIIReader.cxx.diff
diff vtkDataArrayTemplate.txx.diff (4,659) 2015-07-06 21:37
https://www.vtk.org/Bug/file/9836/vtkDataArrayTemplate.txx.diff
png Unoptimized.png (999,013) 2015-07-06 21:37
https://www.vtk.org/Bug/file/9837/Unoptimized.png
png Optimized.png (987,162) 2015-07-06 21:37
https://www.vtk.org/Bug/file/9838/Optimized.png
Issue History
Date ModifiedUsernameFieldChange
2015-03-26 21:24Alan ScottNew Issue
2015-03-26 21:31Alan ScottDescription Updatedbug_revision_view_page.php?rev_id=1047#r1047
2015-03-26 21:32Alan ScottFile Added: vtkExodusIIReader.cxx.diff
2015-03-26 21:32Alan ScottFile Added: ncx.c.diff
2015-06-18 16:56Alan ScottTarget Version => 4.4
2015-06-18 16:57Alan ScottRelationship addedrelated to 0015394
2015-06-18 18:51Alan ScottFile Added: vtkDataArrayTemplate.txx.diff
2015-06-18 18:52Alan ScottNote Added: 0034587
2015-06-29 21:28Alan ScottNote Added: 0034631
2015-07-06 13:08Alan ScottAssigned To => Alan Scott
2015-07-06 20:49Alan ScottFile Deleted: ncx.c.diff
2015-07-06 20:49Alan ScottNote Added: 0034665
2015-07-06 20:50Alan ScottRelationship addedrelated to 0015566
2015-07-06 21:28Alan ScottFile Deleted: vtkExodusIIReader.cxx.diff
2015-07-06 21:28Alan ScottFile Added: vtkExodusIIReader.cxx.diff
2015-07-06 21:30Alan ScottNote Added: 0034666
2015-07-06 21:36Alan ScottFile Deleted: vtkDataArrayTemplate.txx.diff
2015-07-06 21:37Alan ScottFile Added: vtkDataArrayTemplate.txx.diff
2015-07-06 21:37Alan ScottFile Added: Unoptimized.png
2015-07-06 21:37Alan ScottFile Added: Optimized.png
2015-07-06 21:52Alan ScottNote Added: 0034667
2015-07-06 22:14Alan ScottRelationship addedrelated to 0015568
2015-07-06 22:15Alan ScottAssigned ToAlan Scott =>
2015-07-08 16:36Utkarsh AyachitStatusbacklog => todo
2015-08-05 22:09Alan ScottNote Added: 0034900
2015-09-03 10:12Utkarsh AyachitNote Added: 0035162
2015-09-03 16:18Utkarsh AyachitNote Added: 0035165
2015-09-11 16:43Utkarsh AyachitTarget Version4.4 => 5.1
2015-09-11 16:56Utkarsh AyachitStatustodo => customer review
2015-09-11 16:56Utkarsh AyachitFixed in Version => 4.4
2015-09-11 16:56Utkarsh AyachitResolutionopen => fixed
2015-09-11 16:56Utkarsh AyachitAssigned To => Utkarsh Ayachit
2015-11-04 21:27Alan ScottNote Added: 0035423
2015-11-04 21:27Alan ScottStatuscustomer review => closed

Notes
(0034587)
Alan Scott   
2015-06-18 18:52   
Added a third file. Also, I have attached performance screenshots of before and after for vtune on bug 15394.
(0034631)
Alan Scott   
2015-06-29 21:28   
Please ask me before implementing vtkDataArrayTemplate.txx.
(0034665)
Alan Scott   
2015-07-06 20:49   
I deleted ncx.c, moved it to it's own bug.
(0034666)
Alan Scott   
2015-07-06 21:30   
Total time went from (unoptimized) 46.5 seconds to load dataset (Large Tied Blocks ) to 22.7 seconds. Loading all variables, loading as Mode Shapes, default.
(0034667)
Alan Scott   
2015-07-06 21:52   
Test by opening any exodus dataset with time data, turn on mode shapes.
(0034900)
Alan Scott   
2015-08-05 22:09   
Utkarsh - please apply the vtkExodusIIReader.cxx.diff. That one optimizes mode shapes.

As per our discussion, lets defer vtkDataArrayTemplate.txx.diff, since it is being rewritten.
(0035162)
Utkarsh Ayachit   
2015-09-03 10:12   
VTK merge request: https://gitlab.kitware.com/vtk/vtk/merge_requests/622 [^]
(0035165)
Utkarsh Ayachit   
2015-09-03 16:18   
The vtkExodusIIReader fix has been merged in VTK.
(0035423)
Alan Scott   
2015-11-04 21:27   
I opened vtkExodusIIReader.cxx.diff, file is changed correctly. Tested, works ok. Master, Linux, local server, OGL2